Updater breaks OC leaving apps empty #280

Closed
Phiber2000 opened this Issue Mar 16, 2016 · 8 comments

Projects

None yet

3 participants

@Phiber2000
Contributor

Commit 6c88f76 breaks OC completely.
What happens:

  • "apps" directory is moved to "__apps"
  • empty "apps" dir is created
  • updater runs (with empty apps dir)
  • updater doesn't report updating apps
  • "apps" stays empty
  • "__apps" stays untouched

--> owncloud broken with empty "apps" dir

@Phiber2000 Phiber2000 changed the title from Update broken to Updater breaks OC leaving apps empty Mar 16, 2016
@LukasReschke
Member
@LukasReschke LukasReschke added the bug label Mar 16, 2016
@VicDeo
Member
VicDeo commented Mar 16, 2016

@Phiber2000 this commit was tested manually before merging.
I don't see how an empty app directory can break the upgrade process.

@VicDeo
Member
VicDeo commented Mar 16, 2016

ah, you probably mean that this step needs to be reverted on failure. Very true.

@Phiber2000
Contributor

I did this manually about 20 times!
It's only succeeding if apps dir isn't present while core upgrade - or removing those 4 new lines.
Tested with daily-stable9.

@Phiber2000
Contributor

Don't ask me why - but the moving back from "__apps" to "apps" isn't executed.

@Phiber2000
Contributor

After some further eval I can say, that the commit itself isn't the problem:
It seems, that $plain = $this->occRunner->run('upgrade'); leads to an exit of the try block.

@Phiber2000
Contributor

You were totally right:

ah, you probably mean that this step needs to be reverted on failure. Very true.

Because:

exception 'Symfony\Component\Process\Exception\ProcessFailedException' with message 'The command "php /media/data0/owncloud/occ upgrade" failed.
Exit Code: 3(Unknown error)

Output:
================
ownCloud is already latest version
@Phiber2000
Contributor

@VicDeo It would be nice, to hear your opinion about the commit #281!
I'm not very familiar with the updater...

@Phiber2000 Phiber2000 closed this in #281 Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment