3rdparty folder not overwritten on update #316

Closed
LukasReschke opened this Issue Apr 13, 2016 · 4 comments

Projects

None yet

3 participants

@LukasReschke LukasReschke self-assigned this Apr 13, 2016
@LukasReschke
Member

It is missing in the array at https://github.com/owncloud/updater/blob/f2023372c602d199990ed8b399d8972afed02745/src/Utils/Locator.php#L53-L86

@VicDeo Any reason why this is excluded there? We need to update the folder on updates as well.

cc @karlitschek @jospoortvliet @DeepDiver1975

@LukasReschke LukasReschke assigned VicDeo and unassigned LukasReschke Apr 13, 2016
@LukasReschke
Member

Also how is this gonna work if in a future release we add new files or a folder somewhere? 😕

@DeepDiver1975
Member

It is missing in the array at https://github.com/owncloud/updater/blob/f2023372c602d199990ed8b399d8972afed02745/src/Utils/Locator.php#L53-L86

maybe related to the fact that the 3rdparty folder can live in a different location?

@VicDeo
Member
VicDeo commented Apr 14, 2016

@DeepDiver1975

maybe related to the fact that the 3rdparty folder can live in a different location?

true.
IIRC we agreed to drop this feature as it seems to be never used.

@VicDeo VicDeo referenced this issue Apr 14, 2016
Merged

Replace 3rdparty #319

@LukasReschke LukasReschke added a commit to owncloud/core that referenced this issue Apr 20, 2016
@LukasReschke LukasReschke Add repair step for updater issues
The updater as shipped with ownCloud =< 9.0.1 has several bugs leading to a not properly executed update. For example the third-party changes are not copied.

This pull request:

1. Ships the third-party files changed since ownCloud 9.0.1 in the resources folder. On update the files are replaced. (owncloud/updater#316)
2. Adds updater/* and _oc_upgrade/* as an exemption to the code integrity checker since the updater is updating in the wrong order. (owncloud/updater#318)
2d37341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment