New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater no longer works updating from 8.2.7 to 9.0.5 #378

Closed
davitol opened this Issue Sep 21, 2016 · 19 comments

Comments

Projects
None yet
3 participants
@davitol

davitol commented Sep 21, 2016

Using this PR for updating owncloud/administration-internal#32

Update from 8.0.7 8.2.7 to 9.0.5. --> After the update, the apps section looks like this:

screen shot 2016-09-21 at 12 57 58

The following error appears if I try to update via daily channel again:
screen shot 2016-09-21 at 13 17 57

running sudo -u www-data ./occ config:list

 "updater": {
            "enabled": "no",
            "installed_version": "0.6",
            "types": ""
        }

@VicDeo @PVince81 any idea? Do not hesitate to ping me via IRC or GitHub and I'll share my testing environment

@davitol davitol added the bug label Sep 21, 2016

@davitol davitol added this to the 9.0.6 milestone Sep 21, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Sep 21, 2016

Member

Hmm, I thought we forced updating from 8.0.7 to 8.0.15 first

Member

PVince81 commented Sep 21, 2016

Hmm, I thought we forced updating from 8.0.7 to 8.0.15 first

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Sep 21, 2016

Member

Which channel did you use that allowed you to skip 8.0.15 ?

Member

PVince81 commented Sep 21, 2016

Which channel did you use that allowed you to skip 8.0.15 ?

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol Sep 21, 2016

@PVince81 TYPO when I wrote the issue. The scenario was 8.2.7 (stable) to 9.0.5 via daily channel. Sorry for the mistake 😞

davitol commented Sep 21, 2016

@PVince81 TYPO when I wrote the issue. The scenario was 8.2.7 (stable) to 9.0.5 via daily channel. Sorry for the mistake 😞

@davitol davitol changed the title from Updater no longer works updating from 8.0.7 to 9.0.5 to Updater no longer works updating from 8.2.7 to 9.0.5 Sep 21, 2016

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Sep 21, 2016

Member

Updater app should be disabled for 9.0 because there is a standalone updater there (which is not an app)

Member

VicDeo commented Sep 21, 2016

Updater app should be disabled for 9.0 because there is a standalone updater there (which is not an app)

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo
Member

VicDeo commented Sep 21, 2016

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol Sep 22, 2016

@davitol does patching with https://github.com/owncloud/core/pull/26031/files help?

@VicDeo That patch is for master 9.2 version and the problem appears after upgrading to 9.0.5.
I don't know how can I apply that patch to my server

davitol commented Sep 22, 2016

@davitol does patching with https://github.com/owncloud/core/pull/26031/files help?

@VicDeo That patch is for master 9.2 version and the problem appears after upgrading to 9.0.5.
I don't know how can I apply that patch to my server

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Sep 22, 2016

Member

@davitol basically what you need is to replace

        if (!in_array($this->request->getRemoteAddress(), ['::1', '127.0.0.1', 'localhost'])) {

with

        $allowedHosts = ['::1', '127.0.0.1', 'localhost'];
        if (isset($this->request->server['SERVER_ADDR'])){
            array_push($allowedHosts, $this->request->server['SERVER_ADDR']);
        }

        if (!in_array($this->request->getRemoteAddress(), $allowedHosts)) {

in core/Controller/OccController.php
protected function validateRequest

Member

VicDeo commented Sep 22, 2016

@davitol basically what you need is to replace

        if (!in_array($this->request->getRemoteAddress(), ['::1', '127.0.0.1', 'localhost'])) {

with

        $allowedHosts = ['::1', '127.0.0.1', 'localhost'];
        if (isset($this->request->server['SERVER_ADDR'])){
            array_push($allowedHosts, $this->request->server['SERVER_ADDR']);
        }

        if (!in_array($this->request->getRemoteAddress(), $allowedHosts)) {

in core/Controller/OccController.php
protected function validateRequest

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol Sep 22, 2016

@VicDeo Replaced and the problem keeps happening

davitol commented Sep 22, 2016

@VicDeo Replaced and the problem keeps happening

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Sep 22, 2016

Member

@davitol can you please also change https://github.com/owncloud/core/blob/stable9/core/controller/occcontroller.php#L113
to $e->getMessage(), to see a real reason instead of 'Not allowed'?

Member

VicDeo commented Sep 22, 2016

@davitol can you please also change https://github.com/owncloud/core/blob/stable9/core/controller/occcontroller.php#L113
to $e->getMessage(), to see a real reason instead of 'Not allowed'?

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol Oct 4, 2016

@davitol can you please also change https://github.com/owncloud/core/blob/stable9/core/controller/occcontroller.php#L113
to $e->getMessage(), to see a real reason instead of 'Not allowed'?

screen shot 2016-10-04 at 12 28 30

davitol commented Oct 4, 2016

@davitol can you please also change https://github.com/owncloud/core/blob/stable9/core/controller/occcontroller.php#L113
to $e->getMessage(), to see a real reason instead of 'Not allowed'?

screen shot 2016-10-04 at 12 28 30

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Oct 4, 2016

Member

@VicDeo I suspect that this won't work in all setups. This is because sometimes the remote host name in one network is not the same as in another network. So when calling getRemoteUser() from the request it might not always return the same name as seen from the outside.

Member

PVince81 commented Oct 4, 2016

@VicDeo I suspect that this won't work in all setups. This is because sometimes the remote host name in one network is not the same as in another network. So when calling getRemoteUser() from the request it might not always return the same name as seen from the outside.

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Oct 4, 2016

Member

@pvince true. doesn't work for docker containers at least.
I will add fallback to localhost

Member

VicDeo commented Oct 4, 2016

@pvince true. doesn't work for docker containers at least.
I will add fallback to localhost

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Oct 5, 2016

Member

@VicDeo will you add the fallback to the backports or do it separately ?

Member

PVince81 commented Oct 5, 2016

@VicDeo will you add the fallback to the backports or do it separately ?

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Oct 5, 2016

Member

@PVince81 I think it's better test it at once

Member

VicDeo commented Oct 5, 2016

@PVince81 I think it's better test it at once

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81
Member

PVince81 commented Oct 17, 2016

@davitol @VicDeo solved ?

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol Oct 17, 2016

@PVince81 @VicDeo 8.2.7 to 9.0.5. via daily channel no longer has the 'Web executor is not allowed...' issue, but it has the following integrity check problems:

- provisioning_api
    - EXCEPTION
        - OC\IntegrityCheck\Exceptions\InvalidSignatureException
        - Signature data not found.

Raw output
==========
Array
(
    [provisioning_api] => Array
        (
            [EXCEPTION] => Array
                (
                    [class] => OC\IntegrityCheck\Exceptions\InvalidSignatureException
                    [message] => Signature data not found.
                )

        )

)

davitol commented Oct 17, 2016

@PVince81 @VicDeo 8.2.7 to 9.0.5. via daily channel no longer has the 'Web executor is not allowed...' issue, but it has the following integrity check problems:

- provisioning_api
    - EXCEPTION
        - OC\IntegrityCheck\Exceptions\InvalidSignatureException
        - Signature data not found.

Raw output
==========
Array
(
    [provisioning_api] => Array
        (
            [EXCEPTION] => Array
                (
                    [class] => OC\IntegrityCheck\Exceptions\InvalidSignatureException
                    [message] => Signature data not found.
                )

        )

)
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Oct 17, 2016

Member

does the error disappear if you continue updating to the latest ?

it is likely because you updated from 8.2.7 instead of 8.2.8

Member

PVince81 commented Oct 17, 2016

does the error disappear if you continue updating to the latest ?

it is likely because you updated from 8.2.7 instead of 8.2.8

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol Oct 17, 2016

it is likely because you updated from 8.2.7 instead of 8.2.8

It also happens updating from 8.2.8 via daily channel to 9.0.5. Continuing updating the 9.0.5 to 9.1.1 via beta channel the integrity check warnings are no longer shown.

davitol commented Oct 17, 2016

it is likely because you updated from 8.2.7 instead of 8.2.8

It also happens updating from 8.2.8 via daily channel to 9.0.5. Continuing updating the 9.0.5 to 9.1.1 via beta channel the integrity check warnings are no longer shown.

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol Oct 17, 2016

@VicDeo @PVince81 due to Web executor is not allowed...' issue is no longer happening I feel OK about closing this issue

davitol commented Oct 17, 2016

@VicDeo @PVince81 due to Web executor is not allowed...' issue is no longer happening I feel OK about closing this issue

@PVince81 PVince81 closed this Oct 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment