Retrigger integrity check. Fixes #404 #405

Merged
merged 1 commit into from Oct 25, 2016

Projects

None yet

3 participants

@VicDeo
Member
VicDeo commented Oct 25, 2016

To test:

  • Core daily package needs to be patched with owncloud/core#26469
  • This patch is applied on top of the installed OC
@VicDeo VicDeo Retrigger integrity check. Fixes #404
058bfcb
@VicDeo VicDeo added this to the 9.2 milestone Oct 25, 2016
@VicDeo
Member
VicDeo commented Oct 25, 2016
@davitol
davitol commented Oct 25, 2016 edited

To test:

Core daily package needs to be patched with owncloud/core#26469
This patch is applied on top of the installed OC
  1. Core daily package needs to be patched with owncloud/core#26469 done and host in my local update.server.
  2. config.php in updater.server modified in order to get this patched oC
  3. oC server master daily version patched with the current PR #405
  4. version.php file is modified with a 3 days ago date
  5. run update via webUI using daily channel

Current Behaviour:

  • Could not parse a response for status. Please check if the current shell user can run occ command. Raw output: Not allowed is shown via webUI
  • {"reqId":"vQRsK9ZEIZUSEBM7ZlPw","remoteAddr":"172.17.0.1","app":"core","message":"Invalid request to occ controller. Details: \"Web executor is not allowed to run from a host 172.17.0.1\"","level":2,"time":"2016-10-25T08:38:51+00:00","method":"POST","url":"\/index.php\/occ\/status","user":"--"}in owncloud.log

@VicDeo @PVince81 Is it needed to patch daily-master with other patch in other to avoid the web executor error?

@PVince81
Contributor

@davitol yes, very likely. I suggest you apply all previous patches (gist) to avoid update issues and then the one from this PR as well.

@VicDeo
Member
VicDeo commented Oct 25, 2016 edited

@davitol This PR should be applied on the top of the current stable9/master (tomorrow's daily)
as soon as the fixes for not allowed have been just merged and aren't included in today's dailies

They are #400 and #401

@davitol
davitol commented Oct 25, 2016

@VicDeo

  1. Core daily package needs to be patched with owncloud/core#26469 done and host in my local update.server.
  2. config.php in updater.server modified in order to get this patched oC
  3. oC server stable9.1 patched with PR #400
  4. version.php file is modified with a 3 days ago date
  5. run update via webUI using daily channel
  6. Patch applied on the server after the update
  7. Remove .patch file

List of invalid files:

Results
=======
- core
    - INVALID_HASH
        - core/Controller/OccController.php
        - updater/src/Command/PostUpgradeCleanupCommand.php

Raw output
==========
Array
(
    [core] => Array
        (
            [INVALID_HASH] => Array
                (
                    [core/Controller/OccController.php] => Array
                        (
                            [expected] => 00e3f0f97e8632ff1a788686c0d2f365d34e5bb362b19e6f5fc995fa0674e23a810636e5ba19caabc1653758af67c86db7edb2c65b2f2917cca8f80b122b065c
                            [current] => 75a19d8ac2d7e585375d1a581101ad1960cb292b52a2b4a400e4c73e692a4f8d4b672b425a31262e764e15002241272f5209aa8a84caacb4c46cb492c8c81a71
                        )

                    [updater/src/Command/PostUpgradeCleanupCommand.php] => Array
                        (
                            [expected] => 6c25a83ed4c31619fc0e894bace675c5f7ce363f97b24294fee05603451bc531384070e9163f858212d47c45fab97ee6794aa6925024383c85acf82028b4b321
                            [current] => 66cf94ca7e823ebdcaeecf4c36cefdf4c3b51da68dd443bfbbacc68ec97957e144714ce3308e586fdf1250c315ed8bf95dad692c782438733841cc7729c03a4f
                        )

                )

        )

)

This patch is applied on top of the installed OC

I guess it means that it should be applied after updating when the server is in 9.2. status, no?

@VicDeo
Member
VicDeo commented Oct 25, 2016

@davitol these two files have incorrect signature because you patched them in order not to have the whole updater directory content under INVALID_HASH section.

Given that owncloud/core#26469 is already merged If you recheck with the next daily there will be only PostUpgradeCleanupCommand.php in this list.

@davitol
davitol commented Oct 25, 2016

@davitol these two files have incorrect signature because you patched them in order not to have the whole updater directory content under INVALID_HASH section.

Given that owncloud/core#26469 is already merged If you recheck with the next daily there will be only PostUpgradeCleanupCommand.php in this list.

@VicDeo @PVince81 Then if it looks fine with this behaviour 👍
Note: also tested with '9.2' to master-daily and it had the same behaviour

@PVince81 PVince81 merged commit 42770b5 into master Oct 25, 2016

2 checks passed

Scrutinizer 2 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PVince81 PVince81 deleted the fix-integrity-check branch Oct 25, 2016
@PVince81
Contributor

@VicDeo backport ?

@VicDeo
Member
VicDeo commented Oct 25, 2016 edited

Stable9.1: #407
Stable9: #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment