New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken updater fixes #422

Merged
merged 2 commits into from May 5, 2017

Conversation

Projects
None yet
2 participants
@VicDeo
Member

VicDeo commented Apr 25, 2017

  1. use any RC
  2. Switch to daily channel
  3. Click Update
  4. Observe Error 500

@VicDeo VicDeo added this to the 10.0 milestone Apr 25, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 26, 2017

Member

10.0.1, it's too late for 10.0.

What ticket does this fix ? severity ?

Member

PVince81 commented Apr 26, 2017

10.0.1, it's too late for 10.0.

What ticket does this fix ? severity ?

@PVince81 PVince81 modified the milestones: 10.0.1, 10.0 Apr 26, 2017

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo Apr 26, 2017

Member

@PVince81 the ticket that we will have in future when updates for 10.0 are available

Member

VicDeo commented Apr 26, 2017

@PVince81 the ticket that we will have in future when updates for 10.0 are available

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo May 3, 2017

Member

@PVince81 please review

Member

VicDeo commented May 3, 2017

@PVince81 please review

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 3, 2017

Member

Please explain the issue, I can't easily infer it from the code.

Member

PVince81 commented May 3, 2017

Please explain the issue, I can't easily infer it from the code.

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo May 3, 2017

Member

@PVince81 if

use any RC
Switch to daily channel
Click Update
Observe Error 500

Is too long I'd describe it just as "Updater page for OC 10 is completely blank and doesn't work at all"

Member

VicDeo commented May 3, 2017

@PVince81 if

use any RC
Switch to daily channel
Click Update
Observe Error 500

Is too long I'd describe it just as "Updater page for OC 10 is completely blank and doesn't work at all"

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo May 3, 2017

Member

Open Updater click result

screenshot_20170503_213539

Member

VicDeo commented May 3, 2017

Open Updater click result

screenshot_20170503_213539

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 4, 2017

Member

I mean what is the root cause ? Why does it fail ? Is it due to a version parsing issue ? Is it not supposed to run the DB upgrade steps ?

Member

PVince81 commented May 4, 2017

I mean what is the root cause ? Why does it fail ? Is it due to a version parsing issue ? Is it not supposed to run the DB upgrade steps ?

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo May 4, 2017

Member

@PVince81

I mean what is the root cause ?

  1. my stupidity
  2. incompletely removed code in #420
  3. #413 that reads an array from version.php and treats it as a string
Member

VicDeo commented May 4, 2017

@PVince81

I mean what is the root cause ?

  1. my stupidity
  2. incompletely removed code in #420
  3. #413 that reads an array from version.php and treats it as a string
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 5, 2017

Member

@VicDeo fair enough, thanks for the clarification 👍

Member

PVince81 commented May 5, 2017

@VicDeo fair enough, thanks for the clarification 👍

@PVince81 PVince81 merged commit d5da1b2 into master May 5, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PVince81 PVince81 deleted the fix-error branch May 5, 2017

@VicDeo

This comment has been minimized.

Show comment
Hide comment
Member

VicDeo commented May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment