Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn leaving users about running uploads #2590

Closed
PVince81 opened this issue Nov 28, 2019 · 10 comments · Fixed by #4840
Closed

Warn leaving users about running uploads #2590

PVince81 opened this issue Nov 28, 2019 · 10 comments · Fixed by #4840
Assignees
Labels
feature:files Priority:p3-medium Normal priority Topic:good-first-issue beginner friendly task Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

Steps

  1. Upload many files
  2. During the upload, close the browser tab or navigate to another URL

Expected result

A browser warning appears to tell that the upload will cancel if the user proceeds to leave.

Actual result

No warning, upload is cancelled. Confused user.

This should be a metter of adding a window.onbeforeunload or similar to the right places and check for pending uploads (or any other operation, really)

@LukasHirt @hodyroff as discussed

@PVince81 PVince81 added Type:Bug Something isn't working Topic:good-first-issue beginner friendly task feature:files Priority:p3-medium Normal priority labels Nov 28, 2019
@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Nov 28, 2019
@anaswaratrajan
Copy link
Contributor

Hi, I know this issue is old, but it still seems to exist. Can I take this up?

@pascalwengerter
Copy link
Contributor

Hi, I know this issue is old, but it still seems to exist. Can I take this up?

Hey @anaswaratrajan, do you need any more details/help to get started? Happy to have you give it a shot 💪🏽

@anaswaratrajan
Copy link
Contributor

@pascalwengerter, Thanks! I'm currently having some issues with the setup. Can't seem to login with the test credentials. Looking into it.

But I was able to navigate the respective file upload, progress components and get some ideas on how to implement a solution. Will let you know if I'm having trouble.

@pascalwengerter
Copy link
Contributor

@anaswaratrajan just assigned you to this for now ;)

Could you give us an overview on how your local setup looks like/what you've tried to get it running?

@anaswaratrajan
Copy link
Contributor

Followed these instructions and docker to serve OCIS.

@pascalwengerter
Copy link
Contributor

Feel free to join us on https://talk.owncloud.com/channel/phoenix and ping me using the @ for quicker feedback btw!

What's the error message you're getting right now?

@anaswaratrajan
Copy link
Contributor

OCIS_web_issue

@pascalwengerter
Copy link
Contributor

Seems odd, how are you running oCIS (built locally, Docker, using a VM client etc)? And did you kill the web service and replace it with running the yarn serve in the web repo? (Could be interesting not to kill the web service and see if the error persists)

Also, any clues within the logs?

@anaswaratrajan
Copy link
Contributor

I'm running OCIS with Docker.

I tried this docker exec -it <id> ocis kill web to kill the web and it gave a success message as well.
Also tried after running it again.

Found this in logs

http: TLS handshake error from 172.17.0.1:44184: remote error: tls: unknown certificate

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Mar 15, 2021

Edit: It's a bit more complex due to Docker, an easier way would be downloading and running the binary (guide).

Could you confirm that your etc/hosts contains an alias like 127.0.0.1 host.docker.internal and could you try accessing the application via https://host.docker.internal:9200 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:files Priority:p3-medium Normal priority Topic:good-first-issue beginner friendly task Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants