Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Shares" overview #6440

Closed
tbsbdr opened this issue Feb 15, 2022 · 6 comments · Fixed by #6512
Closed

"Shares" overview #6440

tbsbdr opened this issue Feb 15, 2022 · 6 comments · Fixed by #6512
Assignees
Labels
Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Feb 15, 2022

Description

User Stories

  • As a user I want to navigate between "shares with me", "others" and "via link" seamlessly so that I can find the right files quickly.

  • As a user I want an uncluttered left sidebar so that I can orientate and navigate quickly in my ownCloud.

Value

  • Meet enterprise policies: Clear separation of personal files and shared files

Acceptance Criteria

  • Add "Shares" as left sidebar item; on-Click navigates to shared-overview
  • Add "Shared with me", "Shared with others" and "Shared via link" as tabs to the Shares-overview
  • Rename All files to Personal

not in this story: filter options
related: #6448

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] codre review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues

image
image

@tbsbdr tbsbdr changed the title Implement Shared View "Shared" overview Feb 17, 2022
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Feb 21, 2022

Added AC "Rename All files to Personal files" please speak up if this changes the story point estimation.

@phil-davis
Copy link
Contributor

phil-davis commented Feb 21, 2022

A thought: for "ordinary shares" (before the "spaces" concept), each share is a share of some resource that is in someone's "personal files". The "Shared with others" tab shows resources that are in the "all/personal files" of the current user.

So if "Rename All files to Personal files" is done, then there will be a section titled "Personal files" which in fact contains a combination of "really Personal files" and "Personal files that have been shared with others".

IMO that needs some thought - is it misleading to call it "Personal files". Or "Personal files that have been shared with others" could be filtered out of that view - but that introduces hassles for the "owner" user, because then when they share a resource it would disappear from "Personal files". And it might be a resource somewhere down in a folder tree, and not be obvious why it "disappeared".

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Feb 21, 2022

Hi Phil, I'm not sure I've understood you correctly. Is your main concern that the wording "personal files" is misleading because it also includes shared files?

@phil-davis
Copy link
Contributor

Hi Phil, I'm not sure I've understood you correctly. Is your main concern that the wording "personal files" is misleading because it also includes shared files?

yes

In the top post is: Meet enterprise policies: Clear separation of personal files and shared files

There may/will still be shared files "mixed in" the personal files - any personal files/folders of "Alice" that have been shared by "Alice" herself (the "share owner"). And it is tricky to think how to remove those from a Personal Files view.

Use case:

  • the desktop client has synced the following resources to the server for Alice:
    teaching
    teaching/overview.pdf
    teaching/language
    teaching/language/lesson1.pdf
    teaching/language/lesson2.pdf
    teaching/mathematics
    teaching/mathematics/lessonA.pdf
    teaching/mathematics/lessonB.pdf
    teaching/science
    teaching/science/lesson101010.pdf
    teaching/science/lesson101011.pdf
    folder/file.pdf
    shared-top-file.pdf
    top-file.pdf
  • Alice shares teaching/mathematics with Brian
  • Alice shares teaching/science with Carol
  • Alice shares folder/file.pdf with David
  • Alice shares shared-top-file.pdf with David
    A) When Alice selects "Shared" in the web UI, she sees:

Option 1) structure presented in the same tree as it comes from in the "personal" area
folder "folder/file.pdf"
file "shared-top-file.pdf"
folder "teaching"
and when she browses inside "teaching", she sees folders "mathematics" and "science"

Option 2) structure presented with all shares directly at the top level
folder "folder/file.pdf"
file "shared-top-file.pdf"
folder "mathematics"
folder "science"

B) When Alice selects "Personal files" she sees:
Option 1) see "all personal files"
folder "folder/file.pdf"
file "shared-top-file.pdf"
file "top-file.pdf"
folder "teaching"
and if she browses inside "teaching" she sees all the files and folders:
file "overview.pdf"
folder "language"
folder "mathematics"
folder "science"

Option 2) see only the "really personal files" (those that are not shared at all)
file "top-file.pdf"
folder "teaching"
and if she browses inside "teaching" she sees only the unshared files and folders:
file "overview.pdf"
folder "language"
This option might be confusing for Alice,

On the client Windows desktop of Alice, she "really" has all the files and folders structured as in (B) (option 1)

If I was implementing this I would need a decision about the things in the above scenario.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Feb 22, 2022

Ah, okay - got you. Thanks for your words!

  • The basic approach to have a Clear separation of personal files and shared files is, that I won't find any "shared with me" files in my "Personals files" any more. Those will solely live within the Shared endpoint. (Shared with me-view #6448)
  • Whereas "Shared with others" and "Shared via link" will behave like they do right now: On click of a "shared via link-item", I will jump to the respective Item within the "Personal files" view [or a Space - thats new]).

Please also note #6448

@phil-davis
Copy link
Contributor

That sounds fine - technically it is "Clear separation of personal files and received shared files"
As long as developers are clear about that, then the implementation should be well-understood.

@exalate-issue-sync exalate-issue-sync bot changed the title "Shared" overview "Shares" overview Feb 28, 2022
@kulmann kulmann added this to To do in Web Sprint 16 via automation Feb 28, 2022
@pascalwengerter pascalwengerter self-assigned this Mar 2, 2022
@pascalwengerter pascalwengerter moved this from To do to In progress in Web Sprint 16 Mar 2, 2022
@pascalwengerter pascalwengerter moved this from In progress to Review in progress in Web Sprint 16 Mar 8, 2022
Web Sprint 16 automation moved this from Review in progress to Done Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants