Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Do not do earlyFail in CI if full-ci requested #5184

Merged
merged 1 commit into from Jun 2, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 1, 2021

Description

With this PR, a developer can mention full-ci in the PR title, and that will override the earlyFail behavior.

Normally when the first UI test pipeline fails, it cancels the whole build, to save CI resources.

But now, if you mention full-ci in the PR title, then the UI tests pipelines will all run to completion, even if one or more of them fails. That can help a developer to see all the fails "at once". And they can do it without actually editing .drone.star - so the PR can be merged when it passes (there will be no need to revert an edit of .drone.star)

Related Issue

Fixes #5183

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@phil-davis phil-davis self-assigned this Jun 1, 2021
@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/web/15879/6/1
Looks good - the UI test pipeline does not have the earlyFail steps like stopBuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] add ability to run the full webUI CI without stopping early
2 participants