Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Shared with me split #5814

Merged
merged 15 commits into from
Sep 21, 2021
Merged

[full-ci] Shared with me split #5814

merged 15 commits into from
Sep 21, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 16, 2021

Copied over from #5177 - needed to rebase and can't push to the origin of that PR.

Description

The "Shared with me" view shows 2 different lists for pending and accepted shares. On request user can see the declined files (clicking "show declined shares).

Motivation and Context

General UX improvement: Motivate the user to accept or decline the shares through better overview of the statuses and highlighted pending section.

How Has This Been Tested?

UI test scenario: Sharing multiple files through one testing account with another

  • test case 1: pending shares, 3 or less pending shares --> simple list of pending shares
  • test case 2: pending shares, more than 3 shares --> "show all", "show less" option
  • test case 3: no pending shares--> no pending shares list shown
  • test case 4: no accepted shares--> "You are currently not collaborating on other people's resources" message shown, "show declined shares" option appears at pending shares
  • test case 5: accepted shares exist--> list with accepted shares and option to show declined shares appears
  • test case 6: no declined shares--> "No declined files found" message appears
  • test case 7 declined shares exist --> list with declined shares shown on click of "show declined shares"

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Note

Please note that pagination has been removed for the shared with me view in this PR. UX needs a new concept here, as there are multiple tables on the page and the URL params for pagination cannot apply to all at the same time.

General view

Screenshot 2021-09-21 at 16 16 48

Screenshot 2021-09-21 at 16 16 52

@update-docs

This comment has been minimized.

@kulmann kulmann changed the title Shared with me split [full-ci] Shared with me split Sep 16, 2021
@ownclouders
Copy link
Contributor

Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/19119/9/1
The following scenarios passed on retry:

  • webUICreateFilesFolders/createFolders.feature:51

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19119/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/19130/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19130/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

@ownclouders
Copy link
Contributor

Results for oCISSharingPublicExpireAndRoles https://drone.owncloud.com/owncloud/web/19133/62/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:24

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/19133/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:22

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19133/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

@kulmann kulmann marked this pull request as ready for review September 21, 2021 13:08
@kulmann kulmann self-assigned this Sep 21, 2021
@ownclouders
Copy link
Contributor

Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/19139/9/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19139/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

56.8% 56.8% Coverage
2.3% 2.3% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/19142/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:110
  • webUISharingPublicManagement/publicLinkIndicator.feature:27

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏗️

@kulmann kulmann merged commit 5f7a665 into master Sep 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the shared-with-me-split-v2 branch September 21, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants