Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hover effect for context menu to background-color change #6553


Copy link


Changes the hover effect from underline to background-color

Related Issue

Motivation and Context

We find, color hover fits better for actions than the underline effect which is commonly used for links.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests


  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Apply to context menu in the breadcrumb

Copy link

update-docs bot commented Mar 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member Author

The breadcrumb context menu has a slightly different design (padding is set to oc-p-m instead of oc-p-s) and the css for the hover effect is set directly in ods. Should I also make changes there?

Copy link

sonarcloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Results for oC10SharingAndTrashbin
💥 The acceptance tests pipeline failed. The build has been cancelled.

Copy link

Results for oc10SharingIntUsers3
💥 The acceptance tests pipeline failed. The build has been cancelled.

Copy link

@kulmann CI failed because some image couldn't be pulled, but since it's CSS changes only I'd be happy with a force-merge (and would add a changelog item myself in another PR before we do a (pre-)release)

@pascalwengerter pascalwengerter changed the base branch from master to feature-contextmenu-hover-background March 9, 2022 11:23
@pascalwengerter pascalwengerter merged commit 6043b7c into owncloud:feature-contextmenu-hover-background Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Context menu hover improvements
3 participants