Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement group sharing for resources within spaces #6639

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Mar 22, 2022

Description

Resources within a space can now be shared with user groups. Spaces themselves can't be shared with groups, therefore those have been removed from the autocomplete results when adding members to a space.

Needs owncloud-sdk version 3.0.0-alpha.4 to work. However, it's not included in this PR as we already bump it via #6633.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Mar 22, 2022
@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23982/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review March 22, 2022 13:50
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, happy if CI is, too.

@JammingBen JammingBen merged commit 7d8756d into master Mar 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-group-sharing branch March 25, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants