-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Vue 2.7 #7877
[full-ci] Vue 2.7 #7877
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This at least needs |
06a7791
to
c32e0f6
Compare
dcff70b
to
0191c11
Compare
I've updated the After doing that the (unit) test suite looks fairly okay already:
I expect this to go down quite a bit already after |
0191c11
to
986b61b
Compare
795783c
to
f81d795
Compare
Results for oCISSharingPerm2 https://drone.owncloud.com/owncloud/web/29770/66/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L47.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L48.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L49.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L50.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L51.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers_feature-L52.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L54.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L55.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L56.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L57.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L58.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup_feature-L59.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L54.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L55.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L56.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L57.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L58.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L59.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L60.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L61.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L62.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L63.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L64.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L65.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L48.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L49.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L50.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L51.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L52.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers_feature-L53.png |
de17cb0
to
9ad7c26
Compare
cf7458c
to
d00b84e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀 2 small things I noticed:
packages/web-app-files/src/components/SideBar/Shares/Collaborators/RoleDropdown.vue
Show resolved
Hide resolved
0c1d0e4
to
d00b84e
Compare
4f345c2
to
554723c
Compare
SonarCloud Quality Gate failed. |
import { queryItemAsString, useAppDefaults, useRouteQuery } from 'web-pkg/src/composables' | ||
import { defineComponent } from '@vue/composition-api' | ||
import { defineComponent } from 'vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be united with line 39, no? 🥷 Not worth an individual commit though, was just browsing and spotted this. Awesome work btw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice ❤️
@@ -53,8 +48,12 @@ export default defineComponent({ | |||
const store = useStore() | |||
const sharesLoading = computed(() => store.getters['Files/sharesTreeLoading']) | |||
|
|||
const { incomingParentShare, ...rest } = useIncomingParentShare() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so happy with var name rest
, but also don't have a better idea... 🤔
This PR contains the following updates:
2.6.14
->2.7.14
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.