Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space member loading if a user or group was deleted #8336

Merged
merged 1 commit into from Jan 31, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jan 30, 2023

Description

Loading space members died entirely when one of the members was deleted before. This has been fixed by ignoring the errors on the getUser request for deleted users or groups (still appears in the browser console).

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Jan 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit f7e1a6f into master Jan 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-space-members-panel-deleted-entries branch January 31, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot show / add / remove members from spaces
2 participants