Bugfix: Broken re-login after logout fails

[fschade]

Description

After a user logged out, it was no longer possible to re-login without reloading the ocis root domain,
this has now been fixed and only whitelisted query-params are taken into account in the logout url-replace.

How Has This Been Tested?

• unit test
• manual testing

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised

[fschade]

✅ i found another case where it happens, need to fix that too.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[JammingBen]

LGTM and works just fine. Thanks for fixing! 🤗

[kulmann]

Out of curiosity, @fschade was it one specific query param that was breaking the login? Because apparently the details query param doesn't do any harm.

[fschade]

Out of curiosity, @fschade was it one specific query param that was breaking the login? Because apparently the details query param doesn't do any harm.

yes, the state (oidc), we had this multiple times in the query-param ... but there multiple potential other params which shouldnt be there (scope , session_state, code_challenge, code_challenge_method, flow, ....)