Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust missing reshare permissions message #8820

Merged
merged 3 commits into from Apr 17, 2023
Merged

Adjust missing reshare permissions message #8820

merged 3 commits into from Apr 17, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Apr 17, 2023 •
edited

Description

We've changed the missing reshare permission message to be more clear.
For more details see conversation: #8701

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat marked this pull request as ready for review April 17, 2023 08:10
@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit bf819b5 into master Apr 17, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the adjust-no-share-permission branch April 17, 2023 08:51
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spaces] Hide link sharing option if not allowed
2 participants
@lookacat @AlexAndBear