New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use session storage instead of local storage #1612

Merged
merged 1 commit into from Aug 24, 2016

Conversation

Projects
None yet
2 participants
@ChristophWurst
Contributor

ChristophWurst commented Aug 4, 2016

Motivation for switching to this shorter-lived storage:

  • we store sensitive information in the browser storage, which lives forever if you local storage
  • if the cache is old (1d old or older) chances are high it's worthless as the messages in your folders changed already and the cached ones will be deleted anyway
  • cache only speeds up page refreshes, so it doesn't really help if our AJAX calls are slow
  • if we built better data structures on the client side, we don't have to cache stuff. we can simply built up a data structure of accounts, folders and messages and use the data that has already been loaded before

@LukasReschke @jancborchardt @owncloud/mail please review and tell me what you think. Closing a tab or closing the browser will clear the storage, but I could not really notice the interface loading slower.

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst
Contributor

ChristophWurst commented Aug 24, 2016

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Aug 24, 2016

Contributor

Works, doesn’t break anything :) 👍

Contributor

jancborchardt commented Aug 24, 2016

Works, doesn’t break anything :) 👍

@jancborchardt jancborchardt merged commit baa2ba4 into master Aug 24, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jancborchardt jancborchardt deleted the session-storage branch Aug 24, 2016

@plastikschnitzer plastikschnitzer referenced this pull request Sep 23, 2016

Closed

0.6-RC1 bugs #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment