New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirejs for other locations than apps/ #1627

Merged
merged 1 commit into from Aug 25, 2016

Conversation

Projects
None yet
3 participants
@juliushaertl
Contributor

juliushaertl commented Aug 25, 2016

Fix for https://github.com/owncloud/mail/issues/1163

This will use a dynamic baseUrl for require.js to make the mail app work within other app folders than apps/.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 25, 2016

@juliushaertl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @Gomez to be potential reviewers

mention-bot commented Aug 25, 2016

@juliushaertl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @Gomez to be potential reviewers

@ChristophWurst ChristophWurst added this to the 0.5.3 milestone Aug 25, 2016

@ChristophWurst ChristophWurst added the bug label Aug 25, 2016

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Aug 25, 2016

Contributor

@juliushaertl @Gomez what are the steps to test this?

Contributor

ChristophWurst commented Aug 25, 2016

@juliushaertl @Gomez what are the steps to test this?

@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Aug 25, 2016

Contributor

@ChristophWurst You need to add a secound path to the apps_path config.php (https://github.com/nextcloud/server/blob/master/config/config.sample.php#L689-L703)

Install the mail app into the additional apps path, enable it and try to access it.

Without the patch, require.js tries to load all javascript files from "apps/mail/js/..:" but they are stored in e.g. "apps-extra/mail/js/..."

Contributor

juliushaertl commented Aug 25, 2016

@ChristophWurst You need to add a secound path to the apps_path config.php (https://github.com/nextcloud/server/blob/master/config/config.sample.php#L689-L703)

Install the mail app into the additional apps path, enable it and try to access it.

Without the patch, require.js tries to load all javascript files from "apps/mail/js/..:" but they are stored in e.g. "apps-extra/mail/js/..."

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Aug 25, 2016

Contributor

👍 works very nicely, thanks a lot 🚀

Contributor

ChristophWurst commented Aug 25, 2016

👍 works very nicely, thanks a lot 🚀

@ChristophWurst ChristophWurst merged commit 1f89ca8 into master Aug 25, 2016

2 of 3 checks passed

VersionEye Some dependencies have no license.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChristophWurst ChristophWurst deleted the fix-app-folder branch Aug 25, 2016

@plastikschnitzer plastikschnitzer referenced this pull request Sep 23, 2016

Closed

0.6-RC1 bugs #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment