New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type "p" should use real tst #197

Closed
jpmens opened this Issue May 18, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@jpmens

jpmens commented May 18, 2015

Publishes of "t" : "p" appear to use timestamp of last location publish which makes them appear as duplicates when they are published.

Should we use now as tst for these?

@ckrey

This comment has been minimized.

Show comment
Hide comment
@ckrey

ckrey May 18, 2015

Contributor

Publishes of "t" : "p" use timestamp of last location reported by iOS which makes them appear as duplicates when they are published.
Rather than using now instead of tst, we may add "now" as a secondary timestamp, similar to "wtst"

Contributor

ckrey commented May 18, 2015

Publishes of "t" : "p" use timestamp of last location reported by iOS which makes them appear as duplicates when they are published.
Rather than using now instead of tst, we may add "now" as a secondary timestamp, similar to "wtst"

@ckrey ckrey added the enhancement label May 18, 2015

@jpmens

This comment has been minimized.

Show comment
Hide comment
@jpmens

jpmens May 18, 2015

I don't think we should add a second element to the JSON for now: it would a) complicate the issue and b) cause incompatibilities with Android.

Instead, I will document this. Closing.

jpmens commented May 18, 2015

I don't think we should add a second element to the JSON for now: it would a) complicate the issue and b) cause incompatibilities with Android.

Instead, I will document this. Closing.

@jpmens jpmens closed this May 18, 2015

@jpmens

This comment has been minimized.

Show comment
Hide comment
@jpmens

jpmens Jun 17, 2015

I would like to bring this up again. Publishes of "t":"p" use last location reported by iOS (which is fine) and its timestamp.

Is it possible to replace the tst of those publishes by now() without adding a separate JSON element?

The reason I ask (again) is that I find it quite confusing to see a location report with an old tst in it, and I can imagine this will confuse others as well, in spite of our documenting it. :-)

If we can replace the tst by now(), I propose we should do so.

jpmens commented Jun 17, 2015

I would like to bring this up again. Publishes of "t":"p" use last location reported by iOS (which is fine) and its timestamp.

Is it possible to replace the tst of those publishes by now() without adding a separate JSON element?

The reason I ask (again) is that I find it quite confusing to see a location report with an old tst in it, and I can imagine this will confuse others as well, in spite of our documenting it. :-)

If we can replace the tst by now(), I propose we should do so.

@jpmens jpmens reopened this Jun 17, 2015

@ckrey

This comment has been minimized.

Show comment
Hide comment
@ckrey

ckrey Jun 17, 2015

Contributor

done

Contributor

ckrey commented Jun 17, 2015

done

@jpmens

This comment has been minimized.

Show comment
Hide comment
@jpmens

jpmens Jun 17, 2015

Thank you, Christoph.

jpmens commented Jun 17, 2015

Thank you, Christoph.

@jpmens jpmens closed this Jun 17, 2015

ckrey pushed a commit that referenced this issue Jun 17, 2015

Christoph Krey
>Release date: 2015-06-17 for alpha-testers only
[NEW] use real timestamp in "t":"p" location messages #197
[NEW] enable Hosted mode and Beacon parameters via URL, external QR reader or app internal QR scan

ckrey pushed a commit that referenced this issue Jun 17, 2015

Christoph Krey
>Release date: 2015-06-17 for alpha-testers only - resubmitted b/c ap…
…parent app store problems

[NEW] use real timestamp in "t":"p" location messages #197
[NEW] enable Hosted mode and Beacon parameters via URL, external QR reader or app internal QR scan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment