Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand global does not expand nested expressions #176

Closed
ice1000 opened this issue Sep 15, 2019 · 2 comments
Closed

Expand global does not expand nested expressions #176

ice1000 opened this issue Sep 15, 2019 · 2 comments
Assignees
Labels
bug Something isn't working reduction Normalization by evaluation

Comments

@ice1000
Copy link
Member

ice1000 commented Sep 15, 2019

voile-rs/src/check/eval.rs

Lines 224 to 231 in 3fe3842

let val = expr.map_neutral(&mut |neut| match neut {
Neutral::Ref(index) => tcs.glob_val(index).ast.clone(),
Neutral::Meta(mi) => match &tcs.meta_context.solution(mi) {
MetaSolution::Solved(val) => *val.clone(),
MetaSolution::Unsolved => panic!("Cannot eval unsolved meta: {:?}", mi),
MetaSolution::Inlined => unreachable!(),
},
neut => Val::Neut(neut),

@ice1000 ice1000 added bug Something isn't working reduction Normalization by evaluation labels Sep 15, 2019
ice1000 added a commit that referenced this issue Sep 15, 2019
@owo-bot
Copy link
Member

owo-bot commented Sep 15, 2019

@ice1000 has created a pull request #177 that might address this issue.
Here's a table of the pull request status:

Status
Age
Last Update
Commit
Checks

@ice1000
Copy link
Member Author

ice1000 commented Sep 15, 2019

Fixed in pr #177

@ice1000 ice1000 closed this as completed Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reduction Normalization by evaluation
Projects
None yet
Development

No branches or pull requests

2 participants