New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWTF should check if postgresql client is installed as well #413

Closed
DePierre opened this Issue Apr 15, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@DePierre
Contributor

DePierre commented Apr 15, 2015

It was decided that the OWTF installation process should check if postgresql-server was installed and running. If not, OWTF would download and start the service on its own.

When trying to reproduce #409, it seems that OWTF is not checking if a postgresql-client was installed. During the installation process, the DB initialisation failed and the process continued.

[*] Running following command
sh /root/owtf/install/db_config_setup.sh /root/owtf
[*] Creating default config at /root/.owtf/db.cfg
[*] Don't forget to edit /root/.owtf/db.cfg
[*] Do you want to create database and user as specified in /root/.owtf/db.cfg [Y/n]?

[+] PostgreSQL server is not running.
[+] Can I start db server for you? [Y/n]

[+] Postgres running on :
[+] OWTF db config points towards 127.0.0.1:5432
[+] Do you want us to save the new settings for OWTF? [Y/n]

[+] New database configuration saved
Error: You must install at least one postgresql-client-<version> package.
[+] The problem seems to be the user role and db mentioned in /root/.owtf/db.cfg. Do you want us to create them? [Y/n]


------------------------- OWTF Database Helper Script -------------------------
                    Helps in creation of user and database                     
-------------------------------------------------------------------------------

[+] Ensure that you have required values in /root/.owtf/db.cfg

Press Enter to continue

Error: You must install at least one postgresql-client-<version> package.
Error: You must install at least one postgresql-client-<version> package.
[*] Installing Zest Jars

Of course, OWTF could not be run after the installation finished since the DB failed to be properly configured.

IMO, whether OWTF should check for a postgresql-client when checking for the server or OWTF should not check for postgresql at all.

@7a

This comment has been minimized.

Show comment
Hide comment
@7a

7a Apr 21, 2015

Member

I would go for:
OWTF should check for a postgresql-client when checking for the server

Well spotted!
On 15 Apr 2015 11:41, "Tao Sauvage" notifications@github.com wrote:

It was decided that the OWTF installation process should check if
postgresql-server was installed and running. If not, OWTF would download
and start the service on its own.

When trying to reproduce #409 #409,
it seems that OWTF is not checking if a postgresql-client was installed.
During the installation process, the DB initialisation failed and the
process continued.

[] Running following command
sh /root/owtf/install/db_config_setup.sh /root/owtf
[
] Creating default config at /root/.owtf/db.cfg
[] Don't forget to edit /root/.owtf/db.cfg[] Do you want to create database and user as specified in /root/.owtf/db.cfg [Y/n]?[+] PostgreSQL server is not running.[+] Can I start db server for you? [Y/n][+] Postgres running on :[+] OWTF db config points towards 127.0.0.1:5432[+] Do you want us to save the new settings for OWTF? [Y/n][+] New database configuration savedError: You must install at least one postgresql-client- package.[+] The problem seems to be the user role and db mentioned in /root/.owtf/db.cfg. Do you want us to create them? [Y/n]------------------------- OWTF Database Helper Script ------------------------- Helps in creation of user and database -------------------------------------------------------------------------------[+] Ensure that you have required values in /root/.owtf/db.cfgPress Enter to continueError: You must install at least one postgresql-client- package.Error: You must install at least one postgresql-client- package.[*] Installing Zest Jars

Of course, OWTF could not be run after the installation finished since the
DB failed to be properly configured.

IMO, whether OWTF should check for a postgresql-client when checking for
the server or OWTF should not check for postgresql at all.


Reply to this email directly or view it on GitHub
#413.

Member

7a commented Apr 21, 2015

I would go for:
OWTF should check for a postgresql-client when checking for the server

Well spotted!
On 15 Apr 2015 11:41, "Tao Sauvage" notifications@github.com wrote:

It was decided that the OWTF installation process should check if
postgresql-server was installed and running. If not, OWTF would download
and start the service on its own.

When trying to reproduce #409 #409,
it seems that OWTF is not checking if a postgresql-client was installed.
During the installation process, the DB initialisation failed and the
process continued.

[] Running following command
sh /root/owtf/install/db_config_setup.sh /root/owtf
[
] Creating default config at /root/.owtf/db.cfg
[] Don't forget to edit /root/.owtf/db.cfg[] Do you want to create database and user as specified in /root/.owtf/db.cfg [Y/n]?[+] PostgreSQL server is not running.[+] Can I start db server for you? [Y/n][+] Postgres running on :[+] OWTF db config points towards 127.0.0.1:5432[+] Do you want us to save the new settings for OWTF? [Y/n][+] New database configuration savedError: You must install at least one postgresql-client- package.[+] The problem seems to be the user role and db mentioned in /root/.owtf/db.cfg. Do you want us to create them? [Y/n]------------------------- OWTF Database Helper Script ------------------------- Helps in creation of user and database -------------------------------------------------------------------------------[+] Ensure that you have required values in /root/.owtf/db.cfgPress Enter to continueError: You must install at least one postgresql-client- package.Error: You must install at least one postgresql-client- package.[*] Installing Zest Jars

Of course, OWTF could not be run after the installation finished since the
DB failed to be properly configured.

IMO, whether OWTF should check for a postgresql-client when checking for
the server or OWTF should not check for postgresql at all.


Reply to this email directly or view it on GitHub
#413.

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Dec 6, 2015

Member

Easier solution would be add this to the install script :) .

Member

viyatb commented Dec 6, 2015

Easier solution would be add this to the install script :) .

@viyatb viyatb closed this in 116936a Dec 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment