Installer Issues #534

Closed
anantshri opened this Issue Jan 19, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@anantshri
Member

anantshri commented Jan 19, 2016

  1. Site Down : http://unspecific.com/ssl/ssl-cipher-check.pl
    So wget is still stuck trying to get me ssl-cipher-check.pl
    we should atleast put a limit on number of tries to be made.

  2. We need to ensure following tools are absolutely present
    git, unzip
    We rely on this assuming they will be present where as they might not be.

Would report more inconsistencies if i find something.

@anantshri

This comment has been minimized.

Show comment
Hide comment
@anantshri

anantshri Jan 19, 2016

Member

Why no certificate check for hoppy. Certificate seems right to me. We should not be doing it wrong. ssl is present so use it properly.

command = wget --no-check-certificate https://labs.portcullis.co.uk/download/hoppy-1.8.1.tar.bz2; bunzip2 *; tar xvf *; rm -f *.tar 2> /dev/null

All wget's should have a timelimit --tries=3 is what i am suggesting for all wget

Member

anantshri commented Jan 19, 2016

Why no certificate check for hoppy. Certificate seems right to me. We should not be doing it wrong. ssl is present so use it properly.

command = wget --no-check-certificate https://labs.portcullis.co.uk/download/hoppy-1.8.1.tar.bz2; bunzip2 *; tar xvf *; rm -f *.tar 2> /dev/null

All wget's should have a timelimit --tries=3 is what i am suggesting for all wget

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Jan 19, 2016

Member

@anantshri We do not use git anywhere in the installation process and unzip is present by default on most distros.
However --tries=3 is the way to go for wget. :)

Member

viyatb commented Jan 19, 2016

@anantshri We do not use git anywhere in the installation process and unzip is present by default on most distros.
However --tries=3 is the way to go for wget. :)

@anantshri

This comment has been minimized.

Show comment
Hide comment
@anantshri

anantshri Jan 19, 2016

Member

that's git being used :

command = cd %(RootDir)s/tools/restricted; git clone https://github.com/lightos/Panoptic.git

Member

anantshri commented Jan 19, 2016

that's git being used :

command = cd %(RootDir)s/tools/restricted; git clone https://github.com/lightos/Panoptic.git

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Jan 19, 2016

Member

ah, ok :/

Member

viyatb commented Jan 19, 2016

ah, ok :/

@anantshri

This comment has been minimized.

Show comment
Hide comment
@anantshri

anantshri Jan 19, 2016

Member

Just a quick question. We have distro independent stuff and distro specific stuff. I would assume distro independent stuff should be installed first and then distro specific. But looks like installer is doing inverse. Just wanted to confirm if that's by design or something just ignored.

i suppose https://github.com/owtf/owtf/blob/develop/install/install.py#L119 should be at https://github.com/owtf/owtf/blob/develop/install/install.py#L112 if someone can confirm i will create a pull request.

Member

anantshri commented Jan 19, 2016

Just a quick question. We have distro independent stuff and distro specific stuff. I would assume distro independent stuff should be installed first and then distro specific. But looks like installer is doing inverse. Just wanted to confirm if that's by design or something just ignored.

i suppose https://github.com/owtf/owtf/blob/develop/install/install.py#L119 should be at https://github.com/owtf/owtf/blob/develop/install/install.py#L112 if someone can confirm i will create a pull request.

@anantshri

This comment has been minimized.

Show comment
Hide comment
@anantshri

anantshri Jan 19, 2016

Member

I suppose this check (https://github.com/owtf/owtf/blob/develop/install/install.py#L131) should again only run if we have a kali setup. Which we anyways have already detected above. so a conditional statement should be added. Any specific concerns otherwise i will raise a pull request for this change too.

Member

anantshri commented Jan 19, 2016

I suppose this check (https://github.com/owtf/owtf/blob/develop/install/install.py#L131) should again only run if we have a kali setup. Which we anyways have already detected above. so a conditional statement should be added. Any specific concerns otherwise i will raise a pull request for this change too.

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Jan 19, 2016

Member

@anantshri Yes, some commit must've jumbled up the order. Send the PR :)
Also +1 to the second issue.

Member

viyatb commented Jan 19, 2016

@anantshri Yes, some commit must've jumbled up the order. Send the PR :)
Also +1 to the second issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment