Listing plugins option (-l) not working #556

Closed
DoomTaper opened this Issue Feb 19, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@DoomTaper
Contributor

DoomTaper commented Feb 19, 2016

I tried command ./owtf.py -l net and it shows error:
sqlalchemy.exc.InvalidRequestError: Entity '<class 'framework.db.models.TestGroup'>' has no property 'type'

@viyatb viyatb added this to the OWTF Quality Release milestone Feb 20, 2016

@viyatb viyatb self-assigned this Feb 20, 2016

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Feb 20, 2016

Member

Merged in 4e45d76.

Member

viyatb commented Feb 20, 2016

Merged in 4e45d76.

@viyatb viyatb closed this Feb 20, 2016

@DePierre

This comment has been minimized.

Show comment
Hide comment
@DePierre

DePierre Mar 2, 2016

Contributor

@delta24 at least test the PR. The fix is wrong.

@DoomTaper By commenting the line that raised an error, you are preventing filtering on plugin types. With your fix, instead of having 120 +/- 5 plugins, owtf.py -l web shows 600 +/- 30. Do you understand where that 500 hundreds extra plugins come from? Duplicates. Duplicates that were filtered out by the line you commented.

Contributor

DePierre commented Mar 2, 2016

@delta24 at least test the PR. The fix is wrong.

@DoomTaper By commenting the line that raised an error, you are preventing filtering on plugin types. With your fix, instead of having 120 +/- 5 plugins, owtf.py -l web shows 600 +/- 30. Do you understand where that 500 hundreds extra plugins come from? Duplicates. Duplicates that were filtered out by the line you commented.

@DePierre DePierre reopened this Mar 2, 2016

DePierre added a commit that referenced this issue Mar 2, 2016

@DePierre

This comment has been minimized.

Show comment
Hide comment
@DePierre

DePierre Mar 2, 2016

Contributor

@DoomTaper is working on a proper fix.

Contributor

DePierre commented Mar 2, 2016

@DoomTaper is working on a proper fix.

DoomTaper added a commit to DoomTaper/owtf that referenced this issue Mar 3, 2016

DoomTaper added a commit to DoomTaper/owtf that referenced this issue Mar 3, 2016

Two Minor changes
- Fixes issue #556
- Added WorkerManager.clean_up() to finish() function to exit framework cleanly

DoomTaper added a commit to DoomTaper/owtf that referenced this issue Mar 3, 2016

Two Minor changes
- Fixes issue #556
- Added WorkerManager.clean_up() to finish() function to exit framework cleanly

DoomTaper added a commit to DoomTaper/owtf that referenced this issue Mar 3, 2016

Two Minor changes
- Fixes issue #556
- Added WorkerManager.clean_up() to finish() function to exit framework cleanly

@DePierre DePierre closed this in fa37790 Mar 7, 2016

@DePierre

This comment has been minimized.

Show comment
Hide comment
@DePierre

DePierre Mar 7, 2016

Contributor

@DoomTaper Thank you very much for that fix ;)

Contributor

DePierre commented Mar 7, 2016

@DoomTaper Thank you very much for that fix ;)

@DoomTaper

This comment has been minimized.

Show comment
Hide comment
@DoomTaper

DoomTaper Mar 7, 2016

Contributor

@DePierre I owe it to you ;)

Contributor

DoomTaper commented Mar 7, 2016

@DePierre I owe it to you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment