Debian and Samurai install scripts are not executable. #573

Closed
kdexd opened this Issue Mar 5, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@kdexd
Contributor

kdexd commented Mar 5, 2016

While running install/install.py script in Debian, this error is encountered :

/home/darth_sidious/Documents/owtf/install/debian/install.sh: 53:
/home/darth_sidious/Documents/owtf/install/debian/install.sh:
/home/darth_sidious/Documents/owtf/install/debian/pref.sh: Permission denied

On further inspection of scripts under install directory:
image

It clearly states that install scripts under debian and samurai are not marked executable. These files must be marked executable and made available on upstream HEAD, so the developers need not mark them executable manually on cloning the repository, nor do they face merge conflicts as the executable bit of scripts on local machines is set while that of upstream isn't.

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Mar 5, 2016

Member

A possibly clean solution is to add either shor bash in front of the script names everywhere. That way we don't play with permissions and source remains clean.

Member

viyatb commented Mar 5, 2016

A possibly clean solution is to add either shor bash in front of the script names everywhere. That way we don't play with permissions and source remains clean.

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Mar 5, 2016

Member

Fixed in 00acc5b (wrong issue referenced in merge commit)

Member

viyatb commented Mar 5, 2016

Fixed in 00acc5b (wrong issue referenced in merge commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment