Session Modal breaks for large session names #635

Closed
sachinkamath opened this Issue Mar 26, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@sachinkamath
Contributor

sachinkamath commented Mar 26, 2016

SessionModal handles the sessions in /ui/targets . When a large string is passed as session name, it stretches beyond the size of modal window and breaks the delete functionality

Expected Behavior

The session name should have been truncated.

Current Behavior

The Session Name overflows out of bounds causing delete button to disappear

Possible Solution

  • Truncate the session name / Set a limit (Better Fix)
    (or)
  • Increase the modal size

Steps to Reproduce (for bugs)

  1. Open the Sessions and get the Modal popup.
  2. Enter a long string.

screenshot from 2016-03-26 11 40 57

Your Environment

  • Installation method used: Manual
  • Version/branch used: develop
  • Operating System and version (like Kali, Debian, ArchLinux, etc): Kali Linux
  • pip/setuptools version: 8.1.1
  • sudo access: Yes

@sachinkamath sachinkamath changed the title from Session Modal breaks for bigger session names to Session Modal breaks for large session names Mar 26, 2016

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Mar 26, 2016

Member

@sachinkamath @DePierre @tunnelshade @7a: I think it will be better to truncate the session names to max. 50 chars.

Member

viyatb commented Mar 26, 2016

@sachinkamath @DePierre @tunnelshade @7a: I think it will be better to truncate the session names to max. 50 chars.

@sachinkamath sachinkamath referenced this issue Mar 26, 2016

Merged

Truncated long session names #636

1 of 7 tasks complete
@tunnelshade

This comment has been minimized.

Show comment
Hide comment
@tunnelshade

tunnelshade Mar 28, 2016

Member

@delta24 Yes, put a limit on it. 50 characters make sense

Member

tunnelshade commented Mar 28, 2016

@delta24 Yes, put a limit on it. 50 characters make sense

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Apr 1, 2016

Member

@tunnelshade should we also start implementing length limits in the sqlalchemy models itself?

Member

viyatb commented Apr 1, 2016

@tunnelshade should we also start implementing length limits in the sqlalchemy models itself?

@tunnelshade

This comment has been minimized.

Show comment
Hide comment
@tunnelshade

tunnelshade Apr 1, 2016

Member

Yes @delta24 . Then catch for exceptions while creating models.

Member

tunnelshade commented Apr 1, 2016

Yes @delta24 . Then catch for exceptions while creating models.

@viyatb

This comment has been minimized.

Show comment
Hide comment
@viyatb

viyatb Apr 7, 2016

Member

Closed in d9a2cf3.

Member

viyatb commented Apr 7, 2016

Closed in d9a2cf3.

@viyatb viyatb closed this Apr 7, 2016

@viyatb viyatb added this to the OWTF Quality Release milestone Apr 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment