New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -s/--sign-package option. #13

Merged
merged 3 commits into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@erikng
Copy link
Contributor

erikng commented Feb 18, 2017

I noticed you had a CodeSigning branch but it was never merged.

Today I worked on a feature to use the munki scripts to sign the package: munki/munki@66e5005

Now that this is officially merged, I added a -s/--sign-package option into your tool to use this process. I think this is a better approach overall.

For this PR I tried to follow your syntax/linting and overall coding style. My hope is this can be merged without any modifications like last time.

erikng added some commits Feb 18, 2017

add -s/--sign-package option to sign package.
Signed-off-by: Erik Gomez <e@eriknicolasgomez.com>
Update readme for -s/--sign-package option.
Signed-off-by: Erik Gomez <e@eriknicolasgomez.com>
help="Optional tag to sign distribution package with a "
"Developer ID Installer certificate from keychain. Provide "
"the certificate's Common Name. Ex: "
"'Developer ID Installer: Munki (U8PN57A5N2)'")

This comment has been minimized.

@fuzzylogiq

fuzzylogiq Feb 21, 2017

Member

largely happy with this, but the wording in the help should change here. "optional tag" in the previous option refers specifically to a github release tag, so this should say something like "optionally sign..." etc

This comment has been minimized.

@erikng

erikng Feb 21, 2017

Contributor

Sorry about that. I should have noticed this.

@fuzzylogiq fuzzylogiq merged commit 3eda0b8 into ox-it:master Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment