This repository was archived by the owner on Oct 9, 2025. It is now read-only.
refactor(db): store webhookUrl instead #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing object with url, id and token takes significantly more space in the database. So only storing the URL as a string will reduce the size, without losing any of the data. Parse the id, token from the string itself.
IC-71 Don't store webhook id, token and url separately
It's better to just store the URL since it has the token and id in it and can be used directly with discord.js. Also, storing object with url, id and token takes significantly more space in the database. So only storing the URL as a string will reduce the size, without losing any of the data. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing objects with URL, id, and token takes significantly more space in the database. So only storing the URL as a string will reduce the size, without losing any of the data. Parse the id, and token from the string itself.
Resolves IC-71