Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 27, 2025

No description provided.

@graphite-app
Copy link

graphite-app bot commented Nov 27, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Boshen Boshen force-pushed the 11-27-perf_remove_an_allocation_from_module_directory_ branch from 32a06c8 to f480d46 Compare November 27, 2025 15:50
@Boshen Boshen force-pushed the 11-27-perf_remove_an_allocation_from_module_directory_ branch from f480d46 to f4b627e Compare November 27, 2025 15:50
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.40%. Comparing base (2492bd2) to head (f4b627e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   94.39%   94.40%   +0.01%     
==========================================
  Files          17       17              
  Lines        3247     3255       +8     
==========================================
+ Hits         3065     3073       +8     
  Misses        182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025

CodSpeed Performance Report

Merging #880 will degrade performances by 3.31%

Comparing 11-27-perf_remove_an_allocation_from_module_directory_ (f4b627e) with main (2492bd2)

Summary

❌ 1 regression
✅ 11 untouched
⏩ 5 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
small 11.2 µs 11.5 µs -3.31%

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen merged commit f917412 into main Nov 28, 2025
18 checks passed
@Boshen Boshen deleted the 11-27-perf_remove_an_allocation_from_module_directory_ branch November 28, 2025 02:40
@Boshen Boshen mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants