fix(estree): FormalParameters serializer for TS types
#10462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Instrumentation Performance ReportMerging #10462 will not alter performanceComparing Summary
|
leaysgur
commented
Apr 17, 2025
Member
There was a problem hiding this comment.
Could you please:
- Move the serializers lower down in the file, with the other TS-related serializers, below this comment:
oxc/crates/oxc_ast/src/serialize.rs
Lines 1028 to 1030 in 852c8a7
- Add a comment explaining what these 3 converters do.
After making those changes, please feel free to merge yourself.
overlookmotel
force-pushed
the
fix/issue-10068
branch
from
5b99343 to
d209048
Compare
Member
Author
|
In addition to 3 new serializers, existing others for TS-ESTree have been moved under TS section as well. |
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
…e with other serializers for `FormalParameters` (#10496) Pure refactor. Revert a small change made in #10462. `FunctionFormalParameters` serializer acts on `Function`, which is not a TS type (even though the purpose of the custom serializer is to handle a TS-specific field). Keep this serializer with the rest of the serializers related to `FormalParameters`, rather than with the serializers which act on TS-only AST types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10068