Webrtc calls caller UI + playwright setup #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ wip fullscreen video calls
on the recipient side too
probably cause issues on network changes
Bilb
force-pushed
the
setup-test-playwright
branch
from
101f017
to
6ffadf2
Compare
Bilb
force-pushed
the
setup-test-playwright
branch
from
6ffadf2
to
f871ed5
Compare
Bilb
changed the title
|
👍 |
|
The second part of webrtc calls, mainly UI stuffs for answering/starting a call and some logic changes to make cross platform calls work. |
|
Is session safe around webrtc leaks? Or is it not applicable the way session is constructed? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.