Room return info_updates #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works similarly to returning the seqno from post-modifying endpoints, but for room metadata (fields, pinned messages, mods, etc.). This allows a client to track when the expected change should have been applied to the room when there might be concurrent room polling that could race with a pre-update response.
jagerman
force-pushed
the
room-return-info-updates
branch
2 times, most recently
from
a6e6ef2
to
28373ab
Compare
The triggers managing info_updates where not updating when a hidden global mod/admin was added, but that is wrong because mods/admins of the room *do* see those entries and need to know (via a changed room info_updates when polling for new room info) when the mod list changes, even from a hidden global mod change. This updates the trigger to apply regardless of the visible_mod value.
jagerman
force-pushed
the
room-return-info-updates
branch
from
28373ab
to
a203915
Compare
majestrate
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works similarly to returning the seqno from post-modifying endpoints, but for room metadata (fields, pinned messages, mods, etc.).
This allows a client to track when the expected change should have been applied to the room when there might be concurrent room polling that could race with a pre-update response.
This PR also fixes a bug found in the added tests where the room's info_updates wasn't being updated when hidden global mods are added/removed, which would cause Session clients to not update the mods list for such a change.