Skip to content

Go 1.11 compatibility#218

Closed
divoxx wants to merge 2 commits intooxequa:masterfrom
divoxx:master
Closed

Go 1.11 compatibility#218
divoxx wants to merge 2 commits intooxequa:masterfrom
divoxx:master

Conversation

@divoxx
Copy link

@divoxx divoxx commented Sep 21, 2018

With go 1.11, the project's folder does not need to match the application name or import path anymore. The current version uses the path basename as the application name, which causes --run to fail to run the application with a project not found error.

This PR changes run to use go list to get the import path and then extract the name of the application from it.

"bytes"
"errors"
"github.com/oxequa/realize/realize"
"github.com/divoxx/realize/realize"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated prior to merge, if to be merged.

"strings"
"time"

"github.com/divoxx/realize/realize"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated prior to merge, if to be merged.

@frederikhors
Copy link

frederikhors commented Nov 15, 2018

Any news on this, @asoseil?

@u007
Copy link

u007 commented Jan 21, 2019

seems like project has been abandoned

@erikdubbelboer
Copy link

Looks like the project is abandoned yes. I have started a fork here https://github.com/erikdubbelboer/realize with all the pull requests that look good such as this one merged.

thedevper pushed a commit to thedevper/realize that referenced this pull request Oct 15, 2019
thedevper pushed a commit to thedevper/realize that referenced this pull request Oct 16, 2019
thedevper added a commit to thedevper/realize that referenced this pull request Oct 16, 2019
@divoxx divoxx closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants