Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.11 compatibility #218

Closed
wants to merge 2 commits into from
Closed

Go 1.11 compatibility #218

wants to merge 2 commits into from

Conversation

@divoxx
Copy link

@divoxx divoxx commented Sep 21, 2018

With go 1.11, the project's folder does not need to match the application name or import path anymore. The current version uses the path basename as the application name, which causes --run to fail to run the application with a project not found error.

This PR changes run to use go list to get the import path and then extract the name of the application from it.

@@ -3,7 +3,7 @@ package main
import (
"bytes"
"errors"
"github.com/oxequa/realize/realize"
"github.com/divoxx/realize/realize"

This comment has been minimized.

@divoxx

divoxx Sep 21, 2018
Author

This needs to be updated prior to merge, if to be merged.

@@ -8,8 +8,8 @@ import (
"strings"
"time"

"github.com/divoxx/realize/realize"

This comment has been minimized.

@divoxx

divoxx Sep 21, 2018
Author

This needs to be updated prior to merge, if to be merged.

@frederikhors
Copy link

@frederikhors frederikhors commented Nov 15, 2018

Any news on this, @asoseil?

@u007
Copy link

@u007 u007 commented Jan 21, 2019

seems like project has been abandoned

@erikdubbelboer
Copy link

@erikdubbelboer erikdubbelboer commented Jan 21, 2019

Looks like the project is abandoned yes. I have started a fork here https://github.com/erikdubbelboer/realize with all the pull requests that look good such as this one merged.

JamesnaW pushed a commit to JamesnaW/realize that referenced this pull request Oct 15, 2019
JamesnaW pushed a commit to JamesnaW/realize that referenced this pull request Oct 16, 2019
JamesnaW added a commit to JamesnaW/realize that referenced this pull request Oct 16, 2019
@divoxx divoxx closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants