Go 1.11 compatibility #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divoxx
commented
Sep 21, 2018
| @@ -3,7 +3,7 @@ package main | |||
| import ( | |||
| "bytes" | |||
| "errors" | |||
| "github.com/oxequa/realize/realize" | |||
| "github.com/divoxx/realize/realize" | |||
There was a problem hiding this comment.
This needs to be updated prior to merge, if to be merged.
divoxx
commented
Sep 21, 2018
| @@ -8,8 +8,8 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "github.com/divoxx/realize/realize" | |||
There was a problem hiding this comment.
This needs to be updated prior to merge, if to be merged.
|
Any news on this, @asoseil? |
|
seems like project has been abandoned |
|
Looks like the project is abandoned yes. I have started a fork here https://github.com/erikdubbelboer/realize with all the pull requests that look good such as this one merged. |
JamesnaW
pushed a commit
to JamesnaW/realize
that referenced
this pull request
Oct 15, 2019
JamesnaW
pushed a commit
to JamesnaW/realize
that referenced
this pull request
Oct 16, 2019
JamesnaW
added a commit
to JamesnaW/realize
that referenced
this pull request
Oct 16, 2019
REVERT pull request oxequa#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With go 1.11, the project's folder does not need to match the application name or import path anymore. The current version uses the path basename as the application name, which causes
--runto fail to run the application with aproject not founderror.This PR changes
runto usego listto get the import path and then extract the name of the application from it.