This repository was archived by the owner on Jul 17, 2024. It is now read-only.
Allow creating stopped instance. #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqmana
force-pushed
the
luqmana/create-stopped
branch
from
c36b573 to
38fff44
Compare
karencfv
reviewed
Sep 9, 2022
Collaborator
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
Looks like you just need to generate the docs!
cargo run -- generate json -D docs or run test_generate_json with EXPECTORATE=overwrite set please :)
luqmana
force-pushed
the
luqmana/create-stopped
branch
from
38fff44 to
1645019
Compare
Contributor
Author
|
ok, looks like it's just the auth/ssh tests failing now (which is a known issue in CI). All pass locally against latest omicron. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli side updates for oxidecomputer/omicron#1653
This adds a
-s/--startflag to the create operation. If it's omitted, it defaults totruewhich preserves the current behaviour. You can also explicitly specifytrueorfalse. If the flag is passed with no value, it treats that astrue.