Generate boot disk name from image name (#2542)

* Use image name to generate fallback boot disk name

* Update test

* More accurate comment

Author: charliepark

app/forms/instance-create.tsx

@@ -22,6 +22,7 @@ import {
   usePrefetchedApiQuery,
   type ExternalIpCreate,
   type FloatingIp,
+  type Image,
   type InstanceCreate,
   type InstanceDiskAttachment,
   type NameOrId,
@@ -81,17 +82,21 @@ import { nearest10 } from '~/util/math'
 import { pb } from '~/util/path-builder'
 import { GiB } from '~/util/units'
 
-const getBootDiskAttachment = (values: InstanceCreateInput): InstanceDiskAttachment => {
+const getBootDiskAttachment = (
+  values: InstanceCreateInput,
+  images: Array<Image>
+): InstanceDiskAttachment => {
   if (values.bootDiskSourceType === 'disk') {
     return { type: 'attach', name: values.diskSource }
   }
   const source =
     values.bootDiskSourceType === 'siloImage'
       ? values.siloImageSource
       : values.projectImageSource
+  const sourceName = images.find((image) => image.id === source)?.name
   return {
     type: 'create',
-    name: values.bootDiskName || genName(values.name, source),
+    name: values.bootDiskName || genName(values.name, sourceName || source),
     description: `Created as a boot disk for ${values.name}`,
     size: values.bootDiskSize * GiB,
     diskSource: { type: 'image', imageId: source },
@@ -301,7 +306,7 @@ export function CreateInstanceForm() {
               ? { memory: values.memory, ncpus: values.ncpus }
               : { memory: preset.memory, ncpus: preset.ncpus }
 
-          const bootDisk = getBootDiskAttachment(values)
+          const bootDisk = getBootDiskAttachment(values, allImages)
 
           const userData = values.userData
             ? await readBlobAsBase64(values.userData)

test/e2e/instance-create.e2e.ts

@@ -374,9 +374,9 @@ test('maintains selected values even when changing tabs', async ({ page }) => {
   await page.getByRole('button', { name: 'Create instance' }).click()
   await expect(page).toHaveURL(`/projects/mock-project/instances/${instanceName}/storage`)
   await expectVisible(page, [`h1:has-text("${instanceName}")`, 'text=8 GiB'])
-  // when a disk name isn’t assigned, the generated one uses the ID of the image,
-  // so this checks to make sure that the arch-based image — with ID `bd6aa051…` — was used
-  await expectVisible(page, [`text=${instanceName}-bd6aa051`])
+  // when a disk name isn’t assigned, the generated one uses the name of the image,
+  // so this checks to make sure that the arch-based image — with name `arch-2022-06-01` — was used
+  await expectVisible(page, [`text=${instanceName}-${arch}`])
 })
 
 test('does not attach an ephemeral IP when the checkbox is unchecked', async ({ page }) => {