Allow creating stopped instance. #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luqmana
force-pushed
the
luqmana/create-stopped
branch
from
2a00efd to
70b1fc5
Compare
david-crespo
reviewed
Sep 9, 2022
| <DescriptionField id="description" /> | ||
| <CheckboxField id="start-instance" name="start" label="Start Instance"> | ||
| Start Instance | ||
| </CheckboxField> |
Collaborator
There was a problem hiding this comment.
Looks good. As a followup we might want to add a tooltip or something explaining what this means in more detail, but this is fine. We need to do that in a million places. Maybe we could add a description that says "If unchecked, the instance will be created in the stopped state" or something? Doesn't seem too important, really.
Collaborator
There was a problem hiding this comment.
Hm just kidding, I just saw the screenshot and remembered it's a checkbox. I don't think we have a nice way of putting a description on a checkbox.
Contributor
Author
There was a problem hiding this comment.
On the attached label perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console side updates for oxidecomputer/omicron#1653