From a5c21636d4474c53ac51e9900e47d7b85f271fc7 Mon Sep 17 00:00:00 2001 From: David Crespo Date: Thu, 7 Sep 2023 11:45:10 -0500 Subject: [PATCH 1/4] wait why would we not run tests in parallel in CI --- playwright.config.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/playwright.config.ts b/playwright.config.ts index 04a446580f..61e82670e0 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -18,8 +18,6 @@ const config: PlaywrightTestConfig = { forbidOnly: !!process.env.CI, /* Retry on CI only */ retries: process.env.CI ? 2 : 0, - /* Opt out of parallel tests on CI. */ - workers: process.env.CI ? 1 : undefined, timeout: 2 * 60 * 1000, // 2 minutes, surely overkill fullyParallel: true, use: { From 044c122d4ee3e773d8c047b33c794fcd8e743625 Mon Sep 17 00:00:00 2001 From: David Crespo Date: Thu, 7 Sep 2023 11:57:27 -0500 Subject: [PATCH 2/4] curious what it does when we don't say anything --- .github/workflows/lintBuildTest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lintBuildTest.yml b/.github/workflows/lintBuildTest.yml index 4e34a70606..04ff25f5fd 100644 --- a/.github/workflows/lintBuildTest.yml +++ b/.github/workflows/lintBuildTest.yml @@ -96,7 +96,7 @@ jobs: if: steps.playwright-cache.outputs.cache-hit == 'true' run: npx playwright install-deps - name: Run Playwright browser tests - run: npx playwright test --workers=2 --project=${{matrix.browser}} + run: npx playwright test --project=${{matrix.browser}} - uses: actions/upload-artifact@v3 if: always() with: From 85b2daad2ef28dc267b83fc9ed93088764d94f04 Mon Sep 17 00:00:00 2001 From: David Crespo Date: Thu, 7 Sep 2023 12:12:25 -0500 Subject: [PATCH 3/4] tell github actions to use 100% of available cores --- playwright.config.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/playwright.config.ts b/playwright.config.ts index 61e82670e0..045735b71f 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -14,10 +14,12 @@ import { devices } from '@playwright/test' const config: PlaywrightTestConfig = { testDir: './app/test/e2e', testMatch: /\.e2e\.ts/, - /* Fail the build on CI if you accidentally left test.only in the source code. */ + // Fail the build on CI if you accidentally left test.only in the source code forbidOnly: !!process.env.CI, - /* Retry on CI only */ + // Retry on CI only retries: process.env.CI ? 2 : 0, + // use all available cores (2) on github actions. default is 50%, use that locally + workers: process.env.CI ? '100%' : undefined, timeout: 2 * 60 * 1000, // 2 minutes, surely overkill fullyParallel: true, use: { From 617e7a0e42640461713a2308fe51bfcc7676216b Mon Sep 17 00:00:00 2001 From: David Crespo Date: Thu, 7 Sep 2023 12:29:49 -0500 Subject: [PATCH 4/4] why are you doing this to me safari --- app/test/e2e/image-upload.e2e.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/e2e/image-upload.e2e.ts b/app/test/e2e/image-upload.e2e.ts index 97323d6a1e..472b20f545 100644 --- a/app/test/e2e/image-upload.e2e.ts +++ b/app/test/e2e/image-upload.e2e.ts @@ -186,7 +186,7 @@ test.describe('Image upload', () => { // now let's try canceling by clicking out on the background over the side modal await page.getByLabel('4096').click() - await sleep(100) + await sleep(300) // without the onFocusOutside fix this is a higher number expect(confirmCount).toEqual(2)