typescript-eslint v6 + prettier 3.0 #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Oct 26, 2023
| typescript: combinedParser, | ||
| }, | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Not an issue anymore, that's nice
david-crespo
changed the title
david-crespo
commented
Oct 26, 2023
| "@babel/preset-typescript" | ||
| ], | ||
| "plugins": ["@babel/plugin-transform-runtime", "@babel/plugin-proposal-class-properties"] | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
99% sure this was not being used for anything?
david-crespo
commented
Oct 26, 2023
| typeof structuredClone !== 'undefined' | ||
| ? structuredClone(obj) | ||
| : JSON.parse(JSON.stringify(obj)) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This was kind of interesting — my switch to Map for db.diskBulkImportState would not work with this JSON.parse(JSON.stringify(obj)) fallback. Fortunately I don't think there is any situation where this code would hit the fallback. Two-year-old browsers only, basically.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 4, 2023
oxidecomputer/console@bd65b9d...ae8218d * [ae8218df](oxidecomputer/console@ae8218df) bump msw to 2.0.3 for the real safari fix * [9a3f95a9](oxidecomputer/console@9a3f95a9) reduce dev console noise about local assets not served by MSW * [a61ecf24](oxidecomputer/console@a61ecf24) oxidecomputer/console#1809 * [50f3a5b2](oxidecomputer/console@50f3a5b2) bump recharts and react query * [1a2b5656](oxidecomputer/console@1a2b5656) oxidecomputer/console#1808 * [4c01cd68](oxidecomputer/console@4c01cd68) oxidecomputer/console#1800 * [57cc1892](oxidecomputer/console@57cc1892) oxidecomputer/console#1802 * [47d76dbf](oxidecomputer/console@47d76dbf) oxidecomputer/console#1806 * [eee0eb2e](oxidecomputer/console@eee0eb2e) oxidecomputer/console#1805 * [60c2285e](oxidecomputer/console@60c2285e) oxidecomputer/console#1804 * [d9cf1ef1](oxidecomputer/console@d9cf1ef1) bump sort imports plugin for vuln * [ba3a383e](oxidecomputer/console@ba3a383e) bump playwright to 1.39 (fix issue with z-index test)
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 4, 2023
### User-facing fixes * [57cc1892](oxidecomputer/console@57cc1892) oxidecomputer/console#1802 * [47d76dbf](oxidecomputer/console@47d76dbf) oxidecomputer/console#1806 * [60c2285e](oxidecomputer/console@60c2285e) oxidecomputer/console#1804 ### Full summary oxidecomputer/console@bd65b9d...ae8218d * [ae8218df](oxidecomputer/console@ae8218df) bump msw to 2.0.3 for the real safari fix * [9a3f95a9](oxidecomputer/console@9a3f95a9) reduce dev console noise about local assets not served by MSW * [a61ecf24](oxidecomputer/console@a61ecf24) oxidecomputer/console#1809 * [50f3a5b2](oxidecomputer/console@50f3a5b2) bump recharts and react query * [1a2b5656](oxidecomputer/console@1a2b5656) oxidecomputer/console#1808 * [4c01cd68](oxidecomputer/console@4c01cd68) oxidecomputer/console#1800 * [57cc1892](oxidecomputer/console@57cc1892) oxidecomputer/console#1802 * [47d76dbf](oxidecomputer/console@47d76dbf) oxidecomputer/console#1806 * [eee0eb2e](oxidecomputer/console@eee0eb2e) oxidecomputer/console#1805 * [60c2285e](oxidecomputer/console@60c2285e) oxidecomputer/console#1804 * [d9cf1ef1](oxidecomputer/console@d9cf1ef1) bump sort imports plugin for vuln * [ba3a383e](oxidecomputer/console@ba3a383e) bump playwright to 1.39 (fix issue with z-index test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1789
https://typescript-eslint.io/blog/announcing-typescript-eslint-v6
Not that interesting — honestly thought there would be more to it. I put us on
@typescript-eslint/strictand@typescript-eslint/stylisticand only had to turn off two rules. All the comma noise is due to Prettier 3.0.