Update width of time picker to account for wider datetimes #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
The field looks a little wide to me when using a shorter datetime, but that's maybe fine; open to thoughts. (Removing the width altogether has the side effect of changing the position of the larger calendar datepicker.) |
david-crespo
approved these changes
Nov 29, 2023
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
It’s only slightly wider than it was before, so if it’s wide for short dates, it was already an issue. We can fix it separately.
charliepark
deleted the
1728-fix-time-positioning-in-the-date-picker-control
branch
Contributor
We're somewhat constrained by the date picker library since it omits the date when its on the same day – I remember loosely that |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 7, 2023
oxidecomputer/console@ae8218d...1802c28 * [1802c285](oxidecomputer/console@1802c285) oxidecomputer/console#1839 * [ce09b547](oxidecomputer/console@ce09b547) bump postcss-pseudo-classes for fake vuln * [e09b803b](oxidecomputer/console@e09b803b) might as well get vitest 1.0 in there too * [83dd73ee](oxidecomputer/console@83dd73ee) minor bumps for react router, msw, vite, tailwind, recharts * [6ae6beeb](oxidecomputer/console@6ae6beeb) oxidecomputer/console#1829 * [a0bf47aa](oxidecomputer/console@a0bf47aa) oxidecomputer/console#1836 * [6c9420ad](oxidecomputer/console@6c9420ad) oxidecomputer/console#1835 * [64e97b01](oxidecomputer/console@64e97b01) api-diff also takes a commit * [22bef0bb](oxidecomputer/console@22bef0bb) oxidecomputer/console#1833 * [2fe50f51](oxidecomputer/console@2fe50f51) oxidecomputer/console#1810 * [faadb6d3](oxidecomputer/console@faadb6d3) oxidecomputer/console#1832 * [9e82f9ab](oxidecomputer/console@9e82f9ab) oxidecomputer/console#1811 * [5e11fd83](oxidecomputer/console@5e11fd83) tweak api-diff * [dae20577](oxidecomputer/console@dae20577) oxidecomputer/console#1827 * [ed0ef62e](oxidecomputer/console@ed0ef62e) minor tweaks to api-diff script * [1c790d27](oxidecomputer/console@1c790d27) oxidecomputer/console#1819 * [97be7724](oxidecomputer/console@97be7724) oxidecomputer/console#1826 * [87f4d8b8](oxidecomputer/console@87f4d8b8) oxidecomputer/console#1814 * [65ae1212](oxidecomputer/console@65ae1212) oxidecomputer/console#1820 * [5a6dcea7](oxidecomputer/console@5a6dcea7) oxidecomputer/console#1822 * [4e1bbe13](oxidecomputer/console@4e1bbe13) oxidecomputer/console#1821 * [17408f64](oxidecomputer/console@17408f64) oxidecomputer/console#1813
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 7, 2023
### User-facing changes * [1802c285](oxidecomputer/console@1802c285) oxidecomputer/console#1839 * [6ae6beeb](oxidecomputer/console@6ae6beeb) oxidecomputer/console#1829 * [a0bf47aa](oxidecomputer/console@a0bf47aa) oxidecomputer/console#1836 * [9e82f9ab](oxidecomputer/console@9e82f9ab) oxidecomputer/console#1811 * [5a6dcea7](oxidecomputer/console@5a6dcea7) oxidecomputer/console#1822 ### All changes oxidecomputer/console@ae8218d...1802c28 * [1802c285](oxidecomputer/console@1802c285) oxidecomputer/console#1839 * [ce09b547](oxidecomputer/console@ce09b547) bump postcss-pseudo-classes for fake vuln * [e09b803b](oxidecomputer/console@e09b803b) might as well get vitest 1.0 in there too * [83dd73ee](oxidecomputer/console@83dd73ee) minor bumps for react router, msw, vite, tailwind, recharts * [6ae6beeb](oxidecomputer/console@6ae6beeb) oxidecomputer/console#1829 * [a0bf47aa](oxidecomputer/console@a0bf47aa) oxidecomputer/console#1836 * [6c9420ad](oxidecomputer/console@6c9420ad) oxidecomputer/console#1835 * [64e97b01](oxidecomputer/console@64e97b01) api-diff also takes a commit * [22bef0bb](oxidecomputer/console@22bef0bb) oxidecomputer/console#1833 * [2fe50f51](oxidecomputer/console@2fe50f51) oxidecomputer/console#1810 * [faadb6d3](oxidecomputer/console@faadb6d3) oxidecomputer/console#1832 * [9e82f9ab](oxidecomputer/console@9e82f9ab) oxidecomputer/console#1811 * [5e11fd83](oxidecomputer/console@5e11fd83) tweak api-diff * [dae20577](oxidecomputer/console@dae20577) oxidecomputer/console#1827 * [ed0ef62e](oxidecomputer/console@ed0ef62e) minor tweaks to api-diff script * [1c790d27](oxidecomputer/console@1c790d27) oxidecomputer/console#1819 * [97be7724](oxidecomputer/console@97be7724) oxidecomputer/console#1826 * [87f4d8b8](oxidecomputer/console@87f4d8b8) oxidecomputer/console#1814 * [65ae1212](oxidecomputer/console@65ae1212) oxidecomputer/console#1820 * [5a6dcea7](oxidecomputer/console@5a6dcea7) oxidecomputer/console#1822 * [4e1bbe13](oxidecomputer/console@4e1bbe13) oxidecomputer/console#1821 * [17408f64](oxidecomputer/console@17408f64) oxidecomputer/console#1813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just updates the width of the datetime picker container so it can handle wider values. Although the original bug report shows the split line when the local datetime uses a leading zero, we'd see this same bug for certain datetimes with "wider" two-digit numbers in locales, as in the screenshots here.
Broken / split:
Fixed / single-line:
