Skip to content

Firewall rule improvements #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 21 commits into from
Jan 29, 2024
Merged

Firewall rule improvements #1887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8c48bf4
Table improvements
benjaminleonard Jan 15, 2024
211b9a2
Firewall rule form improvements
benjaminleonard Jan 15, 2024
c13cfec
Use same labels as API
benjaminleonard Jan 16, 2024
2984d45
Test titleCase
benjaminleonard Jan 16, 2024
6789fc8
Checkout `CheckboxGroup` from `ssh-key-select`
benjaminleonard Jan 16, 2024
4cd5f69
Add `CheckboxGroupField`
benjaminleonard Jan 16, 2024
bed7982
Remove unused prop
benjaminleonard Jan 16, 2024
2bbc392
Disable grouping (commas) on number field
benjaminleonard Jan 16, 2024
8849ed7
Fix test
benjaminleonard Jan 16, 2024
71e8e64
Actually fix test
benjaminleonard Jan 16, 2024
14dba3b
Merge branch 'main' into firewall-rule-improvements
david-crespo Jan 26, 2024
d14332c
undo checkbox thing
david-crespo Jan 26, 2024
31b884c
prefetch subnets and firewall rules, sort by priority, better col order
david-crespo Jan 26, 2024
2f5b3b1
Merge branch 'main' into firewall-rule-improvements
benjaminleonard Jan 29, 2024
16deaac
Blocking out routes (incomplete)
benjaminleonard Jan 29, 2024
36ad38f
Revert "Blocking out routes (incomplete)"
david-crespo Jan 29, 2024
fa9c1e8
remove redundant/incorrect test from chatgpt
david-crespo Jan 29, 2024
fae42ca
undo checkbox changes
david-crespo Jan 29, 2024
694a734
postpone clickable name until next PR
david-crespo Jan 29, 2024
430f9fa
epic e2e tests for fiddly hosts and targets tables, fix two bugs!
david-crespo Jan 29, 2024
4e1efe4
do hosts and targets logic slightly nicer
david-crespo Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/components/form/fields/NumberField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ export const NumberFieldInner = <
aria-describedby={tooltipText ? `${id}-label-tip` : undefined}
isDisabled={disabled}
{...field}
formatOptions={{
useGrouping: false,
}}
/>
<ErrorMessage error={error} label={label} />
</>
Expand Down
1 change: 1 addition & 0 deletions app/components/form/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export * from './fields/ImageSelectField'
export * from './fields/ListboxField'
export * from './fields/NameField'
export * from './fields/NetworkInterfaceField'
export * from './fields/NumberField'
export * from './fields/RadioField'
export * from './fields/SubnetListbox'
export * from './fields/TextField'
Expand Down
Loading