Error toasts last 15s instead of 5s, log error info to console #2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
be-nicer-about-errors
branch
from
f68766a to
3a2f55a
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 8, 2024
oxidecomputer/console@2a0693f...238c82b * [238c82bd](oxidecomputer/console@238c82bd) oxidecomputer/console#2132 * [6ae209fb](oxidecomputer/console@6ae209fb) bump omicron to latest (only doc comment changes) * [44515515](oxidecomputer/console@44515515) remove my weird tmux tutorial from the readme * [7383152d](oxidecomputer/console@7383152d) oxidecomputer/console#2131 * [277d8ea0](oxidecomputer/console@277d8ea0) oxql: log timeseries count in the right spot * [d0e90ae1](oxidecomputer/console@d0e90ae1) oxql tweaks * [29b4f879](oxidecomputer/console@29b4f879) oxidecomputer/console#2126 * [fb12f93c](oxidecomputer/console@fb12f93c) regen API client with array response fix * [897eb23d](oxidecomputer/console@897eb23d) oxidecomputer/console#2125 * [a7a11762](oxidecomputer/console@a7a11762) oxql: roll schemasTable into schemas * [b4ef27ce](oxidecomputer/console@b4ef27ce) stick oxql helpers on window.oxql * [c5c8b83d](oxidecomputer/console@c5c8b83d) shrink huge gap under floating IPs page title
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 8, 2024
oxidecomputer/console@2a0693f...7e34c11 * [7e34c118](oxidecomputer/console@7e34c118) fix logging of error messages containing newlines * [238c82bd](oxidecomputer/console@238c82bd) oxidecomputer/console#2132 * [6ae209fb](oxidecomputer/console@6ae209fb) bump omicron to latest (only doc comment changes) * [44515515](oxidecomputer/console@44515515) remove my weird tmux tutorial from the readme * [7383152d](oxidecomputer/console@7383152d) oxidecomputer/console#2131 * [277d8ea0](oxidecomputer/console@277d8ea0) oxql: log timeseries count in the right spot * [d0e90ae1](oxidecomputer/console@d0e90ae1) oxql tweaks * [29b4f879](oxidecomputer/console@29b4f879) oxidecomputer/console#2126 * [fb12f93c](oxidecomputer/console@fb12f93c) regen API client with array response fix * [897eb23d](oxidecomputer/console@897eb23d) oxidecomputer/console#2125 * [a7a11762](oxidecomputer/console@a7a11762) oxql: roll schemasTable into schemas * [b4ef27ce](oxidecomputer/console@b4ef27ce) stick oxql helpers on window.oxql * [c5c8b83d](oxidecomputer/console@c5c8b83d) shrink huge gap under floating IPs page title
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 8, 2024
oxidecomputer/console@2a0693f...7e34c11 * [7e34c118](oxidecomputer/console@7e34c118) fix logging of error messages containing newlines * [238c82bd](oxidecomputer/console@238c82bd) oxidecomputer/console#2132 * [6ae209fb](oxidecomputer/console@6ae209fb) bump omicron to latest (only doc comment changes) * [44515515](oxidecomputer/console@44515515) remove my weird tmux tutorial from the readme * [7383152d](oxidecomputer/console@7383152d) oxidecomputer/console#2131 * [277d8ea0](oxidecomputer/console@277d8ea0) oxql: log timeseries count in the right spot * [d0e90ae1](oxidecomputer/console@d0e90ae1) oxql tweaks * [29b4f879](oxidecomputer/console@29b4f879) oxidecomputer/console#2126 * [fb12f93c](oxidecomputer/console@fb12f93c) regen API client with array response fix * [897eb23d](oxidecomputer/console@897eb23d) oxidecomputer/console#2125 * [a7a11762](oxidecomputer/console@a7a11762) oxql: roll schemasTable into schemas * [b4ef27ce](oxidecomputer/console@b4ef27ce) stick oxql helpers on window.oxql * [c5c8b83d](oxidecomputer/console@c5c8b83d) shrink huge gap under floating IPs page title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some other work in progress that is more elaborate, but I'm not sure we will be able to make it work. This, however, is definitely fine and should be quite useful for internal debugging at least.
Closes #1945
The key thing is that unlike the network tab, this will log regardless of whether the dev tools are open at request time, so you can open the console after the fact. This will not stick around across refreshes however (unless
Persist logsis on in the dev tools).