Skip to content

Add create and edit functionality to anti-affinity groups - #2775

Merged
david-crespo merged 57 commits into
mainfrom
affinity-create-edit
Apr 8, 2025
Merged

david-crespo merged 57 commits into
mainfrom
affinity-create-edit

Conversation

@charliepark

@charliepark charliepark commented Apr 2, 2025 •

Copy link
Copy Markdown
Contributor

This PR adds some functionality to anti-affinity groups, mainly in the "adding and removing instances" vein. Also, editing an anti-affinity group's name and description.

Once this PR is merged, the following items from #2771 will be functional.

  • create anti-affinity group button and modal
  • add member instance to anti-affinity group
    • from group page
    • ❌ from instance's Settings tab
  • remove instance from anti-affinity group
    • from group page
    • ❌ from instance's Settings tab
  • edit group (name, description)
Screenshot 2025-04-02 at 4 53 54 PM Screenshot 2025-04-02 at 4 54 01 PM Screenshot 2025-04-02 at 4 54 39 PM Screenshot 2025-04-02 at 4 54 50 PM

@vercel

vercel Bot commented Apr 2, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Apr 7, 2025 9:20pm

@charliepark charliepark changed the title Affinity create edit Add create and edit functionality to anti-affinity groups Apr 2, 2025
Comment thread app/forms/anti-affinity-group-edit.tsx Resolved
Comment thread app/table/columns/common.tsx Resolved
@david-crespo

Copy link
Copy Markdown
Collaborator

Type -> group type in column header + dropped description column. We tend to only put the description in when we don't have enough other columns. I feel it's a lot more manageable now somehow. Ben approved.

I'm still not satisfied with the copy about policy in the popover, the policy tooltip, and the policy field on the form — will be poking at it a bit more today.

image

@david-crespo

Copy link
Copy Markdown
Collaborator

Actually going with this. I was worried that it wasn't clear enough when you get to the page (or even before, since the sidebar is affected too) that what we're talking about is groups. "New group" in the button wasn't enough for me.

image image

@david-crespo

david-crespo commented Apr 7, 2025 •

Copy link
Copy Markdown
Collaborator

Feels a little silly to have three slightly different ways of putting it, but on the other hand that might actually help.

@david-crespo david-crespo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeehaw

yeehaw.mp4

This branch was successfully deployed

1 active deployment
Preview — 696484e3 Deployed Apr 7, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants