Consolidate client data #1014
Merged
Consolidate client data #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftwo
approved these changes
Nov 14, 2023
Contributor
leftwo
left a comment
leftwo
left a comment
There was a problem hiding this comment.
Thanks for the meet and the walk through of io_state_count()
mkeeter
force-pushed
the
consolidate-client-data
branch
from
c55e5f1 to
2a9984c
Compare
jmpesp
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the Crucible upstairs spends a lot of time fighting over the lock on the single
Mutex<Downstairs>.Eventually, I'd like to move data into separate per-downstairs tasks that own their data and communicate via message-passing (see oxidecomputer/omicron#4332).
This PR is a (mostly) purely mechanical step in that direction: it converts a bunch of individual
ClientData<T>into a singleClientData<DownstairsClient>; basically a struct-of-arrays → array-of-structs transform. Then, functions which only use data within a singleDownstairsClientare moved into members functions on thatstruct.