-
Notifications
You must be signed in to change notification settings - Fork 26
Implement read decryption offloading #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Running with the change above (8f3ba46) to only defer > 8 KiB read decryption, I'm only seeing a small improvement (42.7 -> 44.2 MiB/s). This is still below the performance on |
|
Re-running on Crucible |
|
I am not getting the exact same numbers you are on my test setup, but I am getting a similar ratio of improvement. about 40-45% better for 16k reads, 75-80% better for 4M reads. |
264cbef to
f2f67ff
Compare
9d9f15f to
a448bda
Compare

Analogous to #1066 , this PR moves read decryption into the rayon thread pool. It uses exactly the same infrastructure (particularly
DeferredQueue), and is implemented in a very similar way.I need to do some benchmarking before this goes in, but wanted to open it for review early.