Switch to unbounded queues #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpesp
approved these changes
Apr 10, 2024
mkeeter
added a commit
that referenced
this pull request
Apr 19, 2024
#1256 allowed `DownstairsClient::send` to become synchronous, but left it `async` to avoid touching too many LOC. This PR makes that single change, then turns the crank until `rustc` and `clippy` stop complaining. The result is pretty nice: waiting for events in `Upstairs::select` remains async, but applying them becomes synch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another standalone prep PR for #1252
We are planning to use backpressure alone to limit queue lengths for an
Activedownstairs, removing theIO_MAX_ACTIVE_JOBS/BYTESfault condition; using bounded queues doesn't make sense any more (and gives a false sense of security).Using unbounded queues is more honest about our strategy, and also removes
asyncfrom large chunks of the codebase. The latter isn't done in this PR (to avoid churn), but onceDownstairsClient::sendis made sync, it will ripple through a bunch of places!