From 8c44c1d65bad8cb8c24d603156e673a427ce87cf Mon Sep 17 00:00:00 2001 From: David Crespo Date: Mon, 8 Jul 2024 16:43:08 -0500 Subject: [PATCH 1/2] fix underline color in admonition blocks --- components/src/assets/asciidoc.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/components/src/assets/asciidoc.css b/components/src/assets/asciidoc.css index b5b5fc51..ad9a7469 100644 --- a/components/src/assets/asciidoc.css +++ b/components/src/assets/asciidoc.css @@ -399,6 +399,7 @@ background-color: var(--base-purple-200); color: var(--base-purple-800); border-color: var(--base-purple-400); + text-decoration-color: var(--base-purple-500); } .asciidoc-body .admonitionblock.caution, @@ -424,6 +425,7 @@ .asciidoc-body .admonitionblock.tip p { color: var(--base-purple-800); + text-decoration-color: var(--base-purple-500); } .asciidoc-body .admonitionblock.caution p code, From a7b36bf66e69d6341a79c65564a37c483e98d48b Mon Sep 17 00:00:00 2001 From: Benjamin Leonard Date: Thu, 28 Nov 2024 11:31:50 +0000 Subject: [PATCH 2/2] All all underlines, more specificity --- components/dist/asciidoc.css | 27 ++++++++++++++++++++------- components/src/assets/asciidoc.css | 29 ++++++++++++++++++++--------- 2 files changed, 40 insertions(+), 16 deletions(-) diff --git a/components/dist/asciidoc.css b/components/dist/asciidoc.css index fc9c3d6b..a89aa00d 100644 --- a/components/dist/asciidoc.css +++ b/components/dist/asciidoc.css @@ -59,7 +59,7 @@ word-wrap: break-word; text-decoration: underline; - text-decoration-color: rgba(var(--content-accent-tertiary-rgb), 0.8); + text-decoration-color: var(--content-accent-tertiary); } /* Use semi-bold for strong */ @@ -361,6 +361,23 @@ @apply my-[1.5rem] flex px-3 py-3; } + .asciidoc-body .admonitionblock a { + text-decoration-color: var(--content-success-tertiary); + } + + .asciidoc-body .admonitionblock.tip a { + text-decoration-color: var(--base-purple-600); + } + + .asciidoc-body .admonitionblock.warning a { + text-decoration-color: var(--content-error-tertiary); + } + + .asciidoc-body .admonitionblock.caution a, + .asciidoc-body .admonitionblock.important a { + text-decoration-color: var(--content-notice-tertiary); + } + .asciidoc-body .admonitionblock strong { @apply text-success; } @@ -378,10 +395,6 @@ @apply border-destructive-secondary; } - .asciidoc-body .admonitionblock.tip .quoteblock { - border-color: var(--base-purple-500); - } - .asciidoc-body .admonitionblock.warning strong { @apply text-destructive; } @@ -559,8 +572,8 @@ @apply border-r-0; } - /* - specificity to handle nested tables + /* + specificity to handle nested tables todo: check if it's needed in any of the other table styles */ .asciidoc-body tbody > tr:last-child > td, diff --git a/components/src/assets/asciidoc.css b/components/src/assets/asciidoc.css index 33c2b932..a89aa00d 100644 --- a/components/src/assets/asciidoc.css +++ b/components/src/assets/asciidoc.css @@ -59,7 +59,7 @@ word-wrap: break-word; text-decoration: underline; - text-decoration-color: rgba(var(--content-accent-tertiary-rgb), 0.8); + text-decoration-color: var(--content-accent-tertiary); } /* Use semi-bold for strong */ @@ -361,6 +361,23 @@ @apply my-[1.5rem] flex px-3 py-3; } + .asciidoc-body .admonitionblock a { + text-decoration-color: var(--content-success-tertiary); + } + + .asciidoc-body .admonitionblock.tip a { + text-decoration-color: var(--base-purple-600); + } + + .asciidoc-body .admonitionblock.warning a { + text-decoration-color: var(--content-error-tertiary); + } + + .asciidoc-body .admonitionblock.caution a, + .asciidoc-body .admonitionblock.important a { + text-decoration-color: var(--content-notice-tertiary); + } + .asciidoc-body .admonitionblock strong { @apply text-success; } @@ -378,10 +395,6 @@ @apply border-destructive-secondary; } - .asciidoc-body .admonitionblock.tip .quoteblock { - border-color: var(--base-purple-500); - } - .asciidoc-body .admonitionblock.warning strong { @apply text-destructive; } @@ -395,7 +408,6 @@ background-color: var(--base-purple-200); color: var(--base-purple-800); border-color: var(--base-purple-400); - text-decoration-color: var(--base-purple-500); } .asciidoc-body .admonitionblock.caution, @@ -421,7 +433,6 @@ .asciidoc-body .admonitionblock.tip p { color: var(--base-purple-800); - text-decoration-color: var(--base-purple-500); } .asciidoc-body .admonitionblock.caution p code, @@ -561,8 +572,8 @@ @apply border-r-0; } - /* - specificity to handle nested tables + /* + specificity to handle nested tables todo: check if it's needed in any of the other table styles */ .asciidoc-body tbody > tr:last-child > td,