Implement image delete

[askfongjojo]

Created a project image and promoted it to silo. When trying to delete it, I got a 500 error:

pisces-2:fio angela$ oxide image list
success
ImageResultsPage {
    items: [
        Image {
            block_size: ByteCount(
                512,
            ),
            description: "ubuntu 20.04 LTS (focal)",
            digest: None,
            id: 129c2be0-6e23-49ac-a1af-f4b8322b0a97,
            name: Name(
                "ubuntu20",
            ),
            os: "ubuntu",
            project_id: None,
            size: ByteCount(
                3221225472,
            ),
            time_created: 2023-05-06T03:23:26.804978Z,
            time_modified: 2023-05-06T03:24:21.781153Z,
            url: None,
            version: "20.04 LTS",
        },
    ],
    next_page: Some(
        "eyJ2IjoidjEiLCJwYWdlX3N0YXJ0Ijp7InNvcnRfYnkiOiJuYW1lX2FzY2VuZGluZyIsInByb2plY3QiOm51bGwsImluY2x1ZGVfc2lsb19pbWFnZXMiOm51bGwsImxhc3Rfc2VlbiI6InVidW50dTIwIn19",
    ),
}
pisces-2:fio angela$ oxide image delete --image ubuntu20
error
Error Response: status: 500 Internal Server Error; headers: {"content-type": "application/json", "x-request-id": "679b0c3e-b715-4316-bf91-75ead9f7cd28", "content-length": "124", "date": "Sat, 06 May 2023 19:26:29 GMT"}; value: Error { error_code: Some("Internal"), message: "Internal Server Error", request_id: "679b0c3e-b715-4316-bf91-75ead9f7cd28" }

Nexus log:

19:26:30.533Z INFO 7f1d61df-321c-4b5b-bc92-10c48de4c432 (dropshot_external): request completed
    error_message_external = Internal Server Error
    error_message_internal = endpoint is not implemented
    local_addr = 172.30.1.5:80
    method = DELETE
    remote_addr = 172.20.17.42:53461
    req_id = 679b0c3e-b715-4316-bf91-75ead9f7cd28
    response_code = 500
    uri = //v1/images/ubuntu20

[david-crespo]

This functionality is not yet implemented. I thought there was an issue for it but I can't find it.

omicron/nexus/src/app/image.rs

Lines 363 to 383 in bed2aeb

	// TODO-MVP: Implement
	pub async fn image_delete(
	self: &Arc<Self>,
	opctx: &OpContext,
	image_lookup: &ImageLookup<'_>,
	) -> DeleteResult {
	match image_lookup {
	ImageLookup::ProjectImage(lookup) => {
	lookup.lookup_for(authz::Action::Delete).await?;
	}
	ImageLookup::SiloImage(lookup) => {
	lookup.lookup_for(authz::Action::Delete).await?;
	}
	};
	let error = Error::InternalError {
	internal_message: "Endpoint not implemented".to_string(),
	};
	Err(self
	.unimplemented_todo(opctx, Unimpl::ProtectedLookup(error))
	.await)
	}

[benjaminleonard]

Was going to suggest we remove this action from the console if it's not implemented but if it's on the FCS list we can leave it.

Any reason why we can't use "Endpoint not implemented" as the external error message too? Ran into this today and only spotted it after digging around in the nexus logs.

[david-crespo]

Probably just that nobody ever meant for these TODOs to live so long. We could change the error but I’d lean toward removing the button or disabling it with a tooltip.

[benjaminleonard]

This feels important, should it be moved into 1.0.3?