more first-class environment setup #3006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
One test run seems to have hit #3005: https://github.com/oxidecomputer/omicron/pull/3006/checks?check_run_id=13220424276 |
internet-diglett
approved these changes
May 4, 2023
Contributor
internet-diglett
left a comment
internet-diglett
left a comment
There was a problem hiding this comment.
LGTM, just one comment
docs/how-to-run-simulated.adoc
Outdated
Comment on lines
33
to
39
| Now put these on your PATH with: | ||
|
|
||
| [source,text] | ||
| ---- | ||
| $ source env.sh | ||
| ---- | ||
|
|
Contributor
There was a problem hiding this comment.
We might want to advise running this before installing prerequisites, as I think the script will bail out early if the path isn't already set up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the new
tools/setup_env.sh. Here I'm taking a few steps to first-class it a bit more:env.sh, only because I've seen this convention before. If others have other preferences I'm happy to leave it as it is or call it something else.