[wicketd] Skip updating the RoT if it already has the target version #3240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
approved these changes
Jun 1, 2023
Comment on lines
82
to
83
| slot_a_sha3_256_digest: Option<String>, | ||
| slot_b_sha3_256_digest: Option<String>, |
Contributor
There was a problem hiding this comment.
Hmm don't we have a digest type for this somewhere?
Contributor
Author
There was a problem hiding this comment.
We do have ArtifactHash in installinator. I could do the same thing here, but realistically I think the only use for this is human debugging.
jgallagher
force-pushed
the
wicketd-check-rot-version
branch
from
8bbfa8f to
8940ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips updating the RoT by default (can be overridden by the user from wicket) if the currently active RoT slot's version matches the artifact version in the TUF repository.
Builds on #3239.