From cf59a37e596a05c791b0f062ece1ce5ac313f02d Mon Sep 17 00:00:00 2001
From: Josh <jm.carp@gmail.com>
Date: Thu, 23 Oct 2025 10:36:28 -0400
Subject: [PATCH] clickhouse: configure backup directory.

ClickHouse doesn't allow us to capture backups unless a backup directory is
configured, and we can't configure a backup directory without restarting
ClickHouse. To support backup collection for testing purposes, and in case we
wind up needing to use backups during production operations, configure a
ClickHouse backup directory via clickhouse-admin.
---
 clickhouse-admin/types/src/config.rs                     | 9 +++++++--
 .../types/testutils/replica-server-config.xml            | 8 ++++++--
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/clickhouse-admin/types/src/config.rs b/clickhouse-admin/types/src/config.rs
index aa50684363..9bd0c9cf4a 100644
--- a/clickhouse-admin/types/src/config.rs
+++ b/clickhouse-admin/types/src/config.rs
@@ -102,6 +102,7 @@ impl ReplicaConfig {
         let user_files_path = data_path.clone().join("user_files");
         let temp_files_path = data_path.clone().join("tmp");
         let format_schema_path = data_path.clone().join("format_schemas");
+        let backup_path = data_path.clone().join("backup");
         format!(
             "<!-- generation:{generation} -->
 <clickhouse>
@@ -199,9 +200,13 @@ impl ReplicaConfig {
 
         <!-- Controls how many tasks could be in the queue -->
         <max_tasks_in_queue>1000</max_tasks_in_queue>
-     </distributed_ddl>
+    </distributed_ddl>
 
-     <merge_tree>
+    <backups>
+        <allowed_path>{backup_path}</allowed_path>
+    </backups>
+
+    <merge_tree>
         <!-- Disable sparse column serialization, which we expect to not need -->
         <ratio_of_defaults_for_sparse_serialization>1.0</ratio_of_defaults_for_sparse_serialization>
 
diff --git a/clickhouse-admin/types/testutils/replica-server-config.xml b/clickhouse-admin/types/testutils/replica-server-config.xml
index 5df15ffe39..e5c26c2405 100644
--- a/clickhouse-admin/types/testutils/replica-server-config.xml
+++ b/clickhouse-admin/types/testutils/replica-server-config.xml
@@ -102,9 +102,13 @@
 
         <!-- Controls how many tasks could be in the queue -->
         <max_tasks_in_queue>1000</max_tasks_in_queue>
-     </distributed_ddl>
+    </distributed_ddl>
 
-     <merge_tree>
+    <backups>
+        <allowed_path>./data/backup</allowed_path>
+    </backups>
+
+    <merge_tree>
         <!-- Disable sparse column serialization, which we expect to not need -->
         <ratio_of_defaults_for_sparse_serialization>1.0</ratio_of_defaults_for_sparse_serialization>