[mgs] change SpPoller MissedTickBehavior to Skip
#9429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
approved these changes
Nov 20, 2025
@jgallagher points out to me that the `SpPoller` in MGS' SP metrics module uses a `tokio::time::interval` with the default `MissedTickBehavior`, which is [`Burst`]. This means that if we miss a one-second polling interval because, say, MGS was busy servicing other requests, or due to the vagaries of host OS scheduling, we'll send a burst of SP metrics requests right after each other. This is probably not the ideal behavior here, since the goal is just to do one poll every second. Thus, this commit changes the `SpPoller`'s `Interval` to use the [`Skip`] `MissedTickBehavior`. This way, MGS will perform *up to* one poll per second, with potential gaps if MGS was too busy to poll the SP within a given second. This seems less overwhelming for the poor service processor network stack, in the case that MGS was delayed. Fixes #9428 [`Burst`]: https://docs.rs/tokio/latest/tokio/time/enum.MissedTickBehavior.html#variant.Burst [`Skip`]: https://docs.rs/tokio/latest/tokio/time/enum.MissedTickBehavior.html#variant.Skip
hawkw
force-pushed
the
eliza/unburst-mgs
branch
from
09c59bb to
cfb73a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jgallagher points out to me that the
SpPollerin MGS' SP metrics module uses atokio::time::intervalwith the defaultMissedTickBehavior, which isBurst. This means that if we miss a one-second polling interval because, say, MGS was busy servicing other requests, or due to the vagaries of host OS scheduling, we'll send a burst of SP metrics requests right after each other. This is probably not the ideal behavior here, since the goal is just to do one poll every second.Thus, this commit changes the
SpPoller'sIntervalto use theSkipMissedTickBehavior. This way, MGS will perform up to one poll per second, with potential gaps if MGS was too busy to poll the SP within a given second. This seems less overwhelming for the poor service processor network stack, in the case that MGS was delayed.Fixes #9428