Update hubtools for fixed verify function
#9437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotnick
reviewed
Nov 21, 2025
Contributor
Author
bleh good catch. I tried just updating the branch for testing and it didn't work until I did |
Some refactoring in a dependent lpc55 crate accidentally dropped a check against the root key table hash on the RoT. This resulted in `archive.verify` incorrectly passing in places like wicketd and selecting incorrect RoT images for installation.
Contributor
Author
|
I think the issue is that the actual fix was in the |
labbott
force-pushed
the
fixed_hubtools
branch
from
5684955 to
bac62c2
Compare
plotnick
approved these changes
Nov 21, 2025
Contributor
plotnick
left a comment
plotnick
left a comment
There was a problem hiding this comment.
Looks great, thanks! We are now pulling in two versions of hubtools because gateway-sp-comms (from m-g-s) hasn't been updated yet, but I don't think that should affect the issue we're trying to solve here, nor do I think it's a problem.
labbott
added a commit
that referenced
this pull request
Nov 24, 2025
Omcrion #9437 fixed a bug that could cause an incorrect image to be selected for update. Due to some luck with ordering, this bug should not affect gimlet sleds so long as we have gimlet images show up before cosmo images. Add some checks at build time to make sure this is the case until we have upgraded pass this bug.
jgallagher
added a commit
to oxidecomputer/management-gateway-service
that referenced
this pull request
Nov 24, 2025
Just like oxidecomputer/omicron#9437, pin to a specific revision to avoid issues with git deps and `cargo update`.
jgallagher
added a commit
to oxidecomputer/management-gateway-service
that referenced
this pull request
Nov 24, 2025
Just like oxidecomputer/omicron#9437, pin to a specific revision to avoid issues with git deps and `cargo update`.
labbott
added a commit
that referenced
this pull request
Nov 25, 2025
Omcrion #9437 fixed a bug that could cause an incorrect image to be selected for update. Due to some luck with ordering, this bug should not affect gimlet sleds so long as we have gimlet images show up before cosmo images. Add some checks at build time to make sure this is the case until we have upgraded pass this bug.
labbott
added a commit
that referenced
this pull request
Nov 25, 2025
Omcrion #9437 fixed a bug that could cause an incorrect image to be selected for update. Due to some luck with ordering, this bug should not affect gimlet sleds so long as we have gimlet images show up before cosmo images. Add some checks at build time to make sure this is the case until we have upgraded pass this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring in a dependent lpc55 crate accidentally dropped a check against the root key table hash on the RoT. This resulted in
archive.verifyincorrectly passing in places like wicketd and selecting incorrect RoT images for installation.